Skip to content

Commit bf17744

Browse files
arinc9davem330
authored andcommitted
net: dsa: mt7530: explain exposing MDIO bus of MT7531AE better
Unlike MT7531BE, the GPIO 6-12 pins are not used for RGMII on MT7531AE. Therefore, the GPIO 11-12 pins are set to function as MDC and MDIO to expose the MDIO bus of the switch. Replace the comment with a better explanation. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 9df9aec commit bf17744

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/dsa/mt7530.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2635,7 +2635,10 @@ mt7531_setup(struct dsa_switch *ds)
26352635
if (!priv->p5_sgmii) {
26362636
mt7531_pll_setup(priv);
26372637
} else {
2638-
/* Let ds->user_mii_bus be able to access external phy. */
2638+
/* Unlike MT7531BE, the GPIO 6-12 pins are not used for RGMII on
2639+
* MT7531AE. Set the GPIO 11-12 pins to function as MDC and MDIO
2640+
* to expose the MDIO bus of the switch.
2641+
*/
26392642
mt7530_rmw(priv, MT7531_GPIO_MODE1, MT7531_GPIO11_RG_RXD2_MASK,
26402643
MT7531_EXT_P_MDC_11);
26412644
mt7530_rmw(priv, MT7531_GPIO_MODE1, MT7531_GPIO12_RG_RXD3_MASK,

0 commit comments

Comments
 (0)