Skip to content

Commit c0c6ae2

Browse files
H Hartley Sweetengregkh
authored andcommitted
staging: comedi: rti802: tidy up rti802_ao_insn_read()
To clarify the function a bit, add a local variable for the 'chan' that is being read and change the final return to 'insn->n'. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent df8f09b commit c0c6ae2

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

drivers/staging/comedi/drivers/rti802.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,17 @@ struct rti802_private {
4949

5050
static int rti802_ao_insn_read(struct comedi_device *dev,
5151
struct comedi_subdevice *s,
52-
struct comedi_insn *insn, unsigned int *data)
52+
struct comedi_insn *insn,
53+
unsigned int *data)
5354
{
5455
struct rti802_private *devpriv = dev->private;
56+
unsigned int chan = CR_CHAN(insn->chanspec);
5557
int i;
5658

5759
for (i = 0; i < insn->n; i++)
58-
data[i] = devpriv->ao_readback[CR_CHAN(insn->chanspec)];
60+
data[i] = devpriv->ao_readback[chan];
5961

60-
return i;
62+
return insn->n;
6163
}
6264

6365
static int rti802_ao_insn_write(struct comedi_device *dev,

0 commit comments

Comments
 (0)