Skip to content

Commit c2ff53d

Browse files
fengidriborkmann
authored andcommitted
net: Add priv_flags for allow tx skb without linear
In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For example Mellanox Technologies MT27710 Family [ConnectX-4 Lx] will get the following error message: mlx5_core 0000:3b:00.1 eth1: Error cqe on cqn 0x817, ci 0x8, qn 0x1dbb, opcode 0xd, syndrome 0x1, vendor syndrome 0x68 00000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000030: 00 00 00 00 60 10 68 01 0a 00 1d bb 00 0f 9f d2 WQE DUMP: WQ size 1024 WQ cur size 0, WQE index 0xf, len: 64 00000000: 00 00 0f 0a 00 1d bb 03 00 00 00 08 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 2b 00 08 00 00 00 00 00 05 9e e3 08 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 mlx5_core 0000:3b:00.1 eth1: ERR CQE on SQ: 0x1dbb So a priv_flag is added here to indicate whether the network card supports this feature. Suggested-by: Alexander Lobakin <alobakin@pm.me> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Signed-off-by: Alexander Lobakin <alobakin@pm.me> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: John Fastabend <john.fastabend@gmail.com> Link: https://lore.kernel.org/bpf/20210218204908.5455-3-alobakin@pm.me
1 parent 2463e07 commit c2ff53d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

include/linux/netdevice.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1518,6 +1518,8 @@ struct net_device_ops {
15181518
* @IFF_FAILOVER_SLAVE: device is lower dev of a failover master device
15191519
* @IFF_L3MDEV_RX_HANDLER: only invoke the rx handler of L3 master device
15201520
* @IFF_LIVE_RENAME_OK: rename is allowed while device is up and running
1521+
* @IFF_TX_SKB_NO_LINEAR: device/driver is capable of xmitting frames with
1522+
* skb_headlen(skb) == 0 (data starts from frag0)
15211523
*/
15221524
enum netdev_priv_flags {
15231525
IFF_802_1Q_VLAN = 1<<0,
@@ -1551,6 +1553,7 @@ enum netdev_priv_flags {
15511553
IFF_FAILOVER_SLAVE = 1<<28,
15521554
IFF_L3MDEV_RX_HANDLER = 1<<29,
15531555
IFF_LIVE_RENAME_OK = 1<<30,
1556+
IFF_TX_SKB_NO_LINEAR = 1<<31,
15541557
};
15551558

15561559
#define IFF_802_1Q_VLAN IFF_802_1Q_VLAN
@@ -1584,6 +1587,7 @@ enum netdev_priv_flags {
15841587
#define IFF_FAILOVER_SLAVE IFF_FAILOVER_SLAVE
15851588
#define IFF_L3MDEV_RX_HANDLER IFF_L3MDEV_RX_HANDLER
15861589
#define IFF_LIVE_RENAME_OK IFF_LIVE_RENAME_OK
1590+
#define IFF_TX_SKB_NO_LINEAR IFF_TX_SKB_NO_LINEAR
15871591

15881592
/**
15891593
* struct net_device - The DEVICE structure.

0 commit comments

Comments
 (0)