Skip to content

Commit cde86c6

Browse files
committed
Revert "cnic: don't pass bogus GFP_ flags to dma_alloc_coherent"
JIRA: https://issues.redhat.com/browse/RHEL-2542 Upstream Status: RHEL Only This reverts commit f7eaf7f. bnx2i/cnic currently fails to properly mmap its dma_alloc_coherent buffers through a uio interface without being able to allocate compound pages. Revert this until we can get a better cnic fix. Signed-off-by: Chris Leech <cleech@redhat.com>
1 parent e270ee3 commit cde86c6

File tree

1 file changed

+4
-2
lines changed
  • drivers/net/ethernet/broadcom

1 file changed

+4
-2
lines changed

drivers/net/ethernet/broadcom/cnic.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1027,14 +1027,16 @@ static int __cnic_alloc_uio_rings(struct cnic_uio_dev *udev, int pages)
10271027

10281028
udev->l2_ring_size = pages * CNIC_PAGE_SIZE;
10291029
udev->l2_ring = dma_alloc_coherent(&udev->pdev->dev, udev->l2_ring_size,
1030-
&udev->l2_ring_map, GFP_KERNEL);
1030+
&udev->l2_ring_map,
1031+
GFP_KERNEL | __GFP_COMP);
10311032
if (!udev->l2_ring)
10321033
return -ENOMEM;
10331034

10341035
udev->l2_buf_size = (cp->l2_rx_ring_size + 1) * cp->l2_single_buf_size;
10351036
udev->l2_buf_size = CNIC_PAGE_ALIGN(udev->l2_buf_size);
10361037
udev->l2_buf = dma_alloc_coherent(&udev->pdev->dev, udev->l2_buf_size,
1037-
&udev->l2_buf_map, GFP_KERNEL);
1038+
&udev->l2_buf_map,
1039+
GFP_KERNEL | __GFP_COMP);
10381040
if (!udev->l2_buf) {
10391041
__cnic_free_uio_rings(udev);
10401042
return -ENOMEM;

0 commit comments

Comments
 (0)