drm/sched: Warn if pending_list is not empty

Philipp Stanner · Philipp Stanner · commit d1e5ba835f78 · 2025-07-10T17:07:08.000+02:00
drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Acked-by: Danilo Krummrich <dakr@kernel.org> Signed-off-by: Philipp Stanner <phasta@kernel.org> Link: https://lore.kernel.org/r/20250710125412.128476-7-phasta@kernel.org
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
@@ -1414,6 +1414,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)
 	sched->ready = false;
 	kfree(sched->sched_rq);
 	sched->sched_rq = NULL;
+
+	if (!list_empty(&sched->pending_list))
+		dev_warn(sched->dev, "Tearing down scheduler while jobs are pending!\n");
 }
 EXPORT_SYMBOL(drm_sched_fini);
 

Original file line number	Diff line number	Diff line change
`@@ -1414,6 +1414,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)`
`1414`	`1414`	`sched->ready = false;`
`1415`	`1415`	`kfree(sched->sched_rq);`
`1416`	`1416`	`sched->sched_rq = NULL;`
	`1417`	`+`
	`1418`	`+ if (!list_empty(&sched->pending_list))`
	`1419`	`+ dev_warn(sched->dev, "Tearing down scheduler while jobs are pending!\n");`
`1417`	`1420`	`}`
`1418`	`1421`	`EXPORT_SYMBOL(drm_sched_fini);`
`1419`	`1422`