Skip to content

Commit d2d76b8

Browse files
Benjamin LiJeff Garzik
authored andcommitted
qla3xxx: Remove unnecessary memset() in qla3xxx_send()
We do not need to zero out the 64 byte MAC request I/O control block. By zeroing out the control block and setting it to proper fields is redundant work. This is because in the qla3xxx_send() function we will already set the proper fields in this structure. The unused fields are not looked at by the hardware and do not need to be zeroed out. Signed-off-by: Benjamin Li <benjamin.li@qlogic.com> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
1 parent 546faf0 commit d2d76b8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/qla3xxx.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2188,7 +2188,6 @@ static int ql3xxx_send(struct sk_buff *skb, struct net_device *ndev)
21882188

21892189
}
21902190
mac_iocb_ptr = tx_cb->queue_entry;
2191-
memset((void *)mac_iocb_ptr, 0, sizeof(struct ob_mac_iocb_req));
21922191
mac_iocb_ptr->opcode = qdev->mac_ob_opcode;
21932192
mac_iocb_ptr->flags |= qdev->mb_bit_mask;
21942193
mac_iocb_ptr->transaction_id = qdev->req_producer_index;

0 commit comments

Comments
 (0)