Skip to content

Commit d795848

Browse files
hagarhemBartosz Golaszewski
authored andcommitted
gpio: prevent potential speculation leaks in gpio_device_get_desc()
Userspace may trigger a speculative read of an address outside the gpio descriptor array. Users can do that by calling gpio_ioctl() with an offset out of range. Offset is copied from user and then used as an array index to get the gpio descriptor without sanitization in gpio_device_get_desc(). This change ensures that the offset is sanitized by using array_index_nospec() to mitigate any possibility of speculative information leaks. This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc. Signed-off-by: Hagar Hemdan <hagarhem@amazon.com> Link: https://lore.kernel.org/r/20240523085332.1801-1-hagarhem@amazon.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent 447e140 commit d795848

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpio/gpiolib.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <linux/list.h>
1818
#include <linux/lockdep.h>
1919
#include <linux/module.h>
20+
#include <linux/nospec.h>
2021
#include <linux/of.h>
2122
#include <linux/pinctrl/consumer.h>
2223
#include <linux/seq_file.h>
@@ -198,7 +199,7 @@ gpio_device_get_desc(struct gpio_device *gdev, unsigned int hwnum)
198199
if (hwnum >= gdev->ngpio)
199200
return ERR_PTR(-EINVAL);
200201

201-
return &gdev->descs[hwnum];
202+
return &gdev->descs[array_index_nospec(hwnum, gdev->ngpio)];
202203
}
203204
EXPORT_SYMBOL_GPL(gpio_device_get_desc);
204205

0 commit comments

Comments
 (0)