Skip to content

Commit d8aca2f

Browse files
Bartosz Golaszewskigregkh
authored andcommitted
tty: serial: qcom-geni-serial: stop operations in progress at shutdown
We don't stop transmissions in progress at shutdown. This is fine with FIFO SE mode but with DMA (support for which we'll introduce later) it causes trouble so fix it now. Fixes: e837663 ("tty: serial: qcom_geni_serial: No need to stop tx/rx on UART shutdown") Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20221229155030.418800-2-brgl@bgdev.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent bf8baa0 commit d8aca2f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/tty/serial/qcom_geni_serial.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -880,6 +880,8 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port)
880880
static void qcom_geni_serial_shutdown(struct uart_port *uport)
881881
{
882882
disable_irq(uport->irq);
883+
qcom_geni_serial_stop_tx(uport);
884+
qcom_geni_serial_stop_rx(uport);
883885
}
884886

885887
static int qcom_geni_serial_port_setup(struct uart_port *uport)

0 commit comments

Comments
 (0)