netfilter: nf_tables: remove the genmask parameter

tuqiang · ummakynes · commit da0a090a3c62 · 2025-01-05T11:24:03.000+01:00
The genmask parameter is not used within the nf_tables_addchain function
 body. It should be removed to simplify the function parameter list.

Signed-off-by: tuqiang &lt;tu.qiang35@zte.com.cn&gt;
Signed-off-by: Jiang Kun &lt;jiang.kun2@zte.com.cn&gt;
Reviewed-by: Simon Horman &lt;horms@kernel.org&gt;
Signed-off-by: Pablo Neira Ayuso &lt;pablo@netfilter.org&gt;
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
@@ -2598,9 +2598,8 @@ int nft_chain_add(struct nft_table *table, struct nft_chain *chain)
 
 static u64 chain_id;
 
-static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,
-			      u8 policy, u32 flags,
-			      struct netlink_ext_ack *extack)
+static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 policy,
+			      u32 flags, struct netlink_ext_ack *extack)
 {
 	const struct nlattr * const *nla = ctx->nla;
 	struct nft_table *table = ctx->table;
@@ -3038,7 +3037,7 @@ static int nf_tables_newchain(struct sk_buff *skb, const struct nfnl_info *info,
 					  extack);
 	}
 
-	return nf_tables_addchain(&ctx, family, genmask, policy, flags, extack);
+	return nf_tables_addchain(&ctx, family, policy, flags, extack);
 }
 
 static int nft_delchain_hook(struct nft_ctx *ctx,

Original file line number	Diff line number	Diff line change
`@@ -2598,9 +2598,8 @@ int nft_chain_add(struct nft_table table, struct nft_chain chain)`
`2598`	`2598`
`2599`	`2599`	`static u64 chain_id;`
`2600`	`2600`
`2601`		`-static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,`
`2602`		`- u8 policy, u32 flags,`
`2603`		`- struct netlink_ext_ack *extack)`
	`2601`	`+static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 policy,`
	`2602`	`+ u32 flags, struct netlink_ext_ack *extack)`
`2604`	`2603`	`{`
`2605`	`2604`	`const struct nlattr * const *nla = ctx->nla;`
`2606`	`2605`	`struct nft_table *table = ctx->table;`
`@@ -3038,7 +3037,7 @@ static int nf_tables_newchain(struct sk_buff skb, const struct nfnl_info info,`
`3038`	`3037`	`extack);`
`3039`	`3038`	`}`
`3040`	`3039`
`3041`		`- return nf_tables_addchain(&ctx, family, genmask, policy, flags, extack);`
	`3040`	`+ return nf_tables_addchain(&ctx, family, policy, flags, extack);`
`3042`	`3041`	`}`
`3043`	`3042`
`3044`	`3043`	`static int nft_delchain_hook(struct nft_ctx *ctx,`