Skip to content

Commit da206d6

Browse files
vladimirolteandavem330
authored andcommitted
net: phy: mscc: accept all RGMII species in vsc85xx_mac_if_set
The helper for configuring the pinout of the MII side of the PHY should do so irrespective of whether RGMII delays are used or not. So accept the ID, TXID and RXID variants as well, not just the no-delay RGMII variant. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 4035e81 commit da206d6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/phy/mscc/mscc_main.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,9 @@ static int vsc85xx_mac_if_set(struct phy_device *phydev,
491491
reg_val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1);
492492
reg_val &= ~(MAC_IF_SELECTION_MASK);
493493
switch (interface) {
494+
case PHY_INTERFACE_MODE_RGMII_TXID:
495+
case PHY_INTERFACE_MODE_RGMII_RXID:
496+
case PHY_INTERFACE_MODE_RGMII_ID:
494497
case PHY_INTERFACE_MODE_RGMII:
495498
reg_val |= (MAC_IF_SELECTION_RGMII << MAC_IF_SELECTION_POS);
496499
break;

0 commit comments

Comments
 (0)