Skip to content

Commit db64e7e

Browse files
AngeloGioacchino Del Regnoandersson
authored andcommitted
rpmsg: qcom_smd: Fix redundant channel->registered assignment
In qcom_channel_state_worker(), we are setting channel->registered to true when registering a channel, but this is getting repeated both before and after re-locking the channels_lock spinlock, which is obviously a typo. Remove the assignment done out of the spinlock to fix this redundancy. Fixes: 53e2822 ("rpmsg: Introduce Qualcomm SMD backend") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20220114133259.247726-1-angelogioacchino.delregno@collabora.com
1 parent 18fc82d commit db64e7e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/rpmsg/qcom_smd.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1303,9 +1303,7 @@ static void qcom_channel_state_worker(struct work_struct *work)
13031303

13041304
spin_unlock_irqrestore(&edge->channels_lock, flags);
13051305
qcom_smd_create_device(channel);
1306-
channel->registered = true;
13071306
spin_lock_irqsave(&edge->channels_lock, flags);
1308-
13091307
channel->registered = true;
13101308
}
13111309

0 commit comments

Comments
 (0)