smb3: fix perf regression with cached writes with netfs conversion

smfrench · smfrench · commit edfc6481faf8 · 2024-05-14T17:38:39.000-05:00
Write through mode is for cache=none, not for default (when caching is allowed if we have a lease). Some tests were running much, much more slowly as a result of disabling caching of writes by default. Reviewed-by: David Howells <dhowells@redhat.com> Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de> Fixes: 3ee1a1f ("cifs: Cut over to using netfslib") Signed-off-by: Steve French <stfrench@microsoft.com>
diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c
@@ -34,11 +34,8 @@
 static void cifs_set_netfs_context(struct inode *inode)
 {
 	struct cifsInodeInfo *cifs_i = CIFS_I(inode);
-	struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
 
 	netfs_inode_init(&cifs_i->netfs, &cifs_req_ops, true);
-	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_STRICT_IO)
-		__set_bit(NETFS_ICTX_WRITETHROUGH, &cifs_i->netfs.flags);
 }
 
 static void cifs_set_ops(struct inode *inode)

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,8 @@`
`34`	`34`	`static void cifs_set_netfs_context(struct inode *inode)`
`35`	`35`	`{`
`36`	`36`	`struct cifsInodeInfo *cifs_i = CIFS_I(inode);`
`37`		`- struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);`
`38`	`37`
`39`	`38`	`netfs_inode_init(&cifs_i->netfs, &cifs_req_ops, true);`
`40`		`- if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_STRICT_IO)`
`41`		`- __set_bit(NETFS_ICTX_WRITETHROUGH, &cifs_i->netfs.flags);`
`42`	`39`	`}`
`43`	`40`
`44`	`41`	`static void cifs_set_ops(struct inode *inode)`