fec: Use gpio_set_value_cansleep()

Fabio Estevam · davem330 · commit f4444574a414 · 2015-11-01T12:03:01.000-05:00
We are in a context where we can sleep, and the FEC PHY reset gpio
may be on an I2C expander. Use the cansleep() variant when
setting the GPIO value.

Based on a patch from Russell King for pci-mvebu.c.

Signed-off-by: Fabio Estevam &lt;fabio.estevam@freescale.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
@@ -3262,7 +3262,7 @@ static void fec_reset_phy(struct platform_device *pdev)
 		return;
 	}
 	msleep(msec);
-	gpio_set_value(phy_reset, 1);
+	gpio_set_value_cansleep(phy_reset, 1);
 }
 #else /* CONFIG_OF */
 static void fec_reset_phy(struct platform_device *pdev)

Original file line number	Diff line number	Diff line change
`@@ -3262,7 +3262,7 @@ static void fec_reset_phy(struct platform_device *pdev)`
`3262`	`3262`	`return;`
`3263`	`3263`	`}`
`3264`	`3264`	`msleep(msec);`
`3265`		`- gpio_set_value(phy_reset, 1);`
	`3265`	`+ gpio_set_value_cansleep(phy_reset, 1);`
`3266`	`3266`	`}`
`3267`	`3267`	`#else /* CONFIG_OF */`
`3268`	`3268`	`static void fec_reset_phy(struct platform_device *pdev)`