Skip to content

Commit f813dac

Browse files
Umang Jaingregkh
authored andcommitted
staging: vchiq_core: Drop retry loop on -EINTR
-EINTR is returned by vchiq_queue_message() on receiving a fatal signal to the process. Since the process is deemed to be terminated anyway, do not retry queuing with vchiq_queue_message() on -EINTR. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Link: https://lore.kernel.org/r/20240918163100.870596-7-umang.jain@ideasonboard.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ec5d292 commit f813dac

File tree

1 file changed

+2
-17
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+2
-17
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3269,24 +3269,9 @@ vchiq_queue_message(struct vchiq_instance *instance, unsigned int handle,
32693269
int vchiq_queue_kernel_message(struct vchiq_instance *instance, unsigned int handle, void *data,
32703270
unsigned int size)
32713271
{
3272-
int status;
3273-
3274-
while (1) {
3275-
status = vchiq_queue_message(instance, handle, memcpy_copy_callback,
3276-
data, size);
3277-
3278-
/*
3279-
* vchiq_queue_message() may return -EINTR, so we need to
3280-
* implement a retry mechanism since this function is supposed
3281-
* to block until queued
3282-
*/
3283-
if (status != -EINTR)
3284-
break;
32853272

3286-
msleep(1);
3287-
}
3288-
3289-
return status;
3273+
return vchiq_queue_message(instance, handle, memcpy_copy_callback,
3274+
data, size);
32903275
}
32913276
EXPORT_SYMBOL(vchiq_queue_kernel_message);
32923277

0 commit comments

Comments
 (0)