soundwire: qcom: update status correctly with mask

Srinivas-Kandagatla · vinodkoul · commit f84d41b2a083 · 2023-07-12T22:30:15.000+05:30
SoundWire device status can be incorrectly updated without proper mask, fix this by adding a mask before updating the status. Fixes: c7d49c7 ("soundwire: qcom: add support to new interrupts") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20230525133812.30841-2-srinivas.kandagatla@linaro.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
@@ -540,7 +540,7 @@ static int qcom_swrm_get_alert_slave_dev_num(struct qcom_swrm_ctrl *ctrl)
 		status = (val >> (dev_num * SWRM_MCP_SLV_STATUS_SZ));
 
 		if ((status & SWRM_MCP_SLV_STATUS_MASK) == SDW_SLAVE_ALERT) {
-			ctrl->status[dev_num] = status;
+			ctrl->status[dev_num] = status & SWRM_MCP_SLV_STATUS_MASK;
 			return dev_num;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ static int qcom_swrm_get_alert_slave_dev_num(struct qcom_swrm_ctrl *ctrl)`
`540`	`540`	`status = (val >> (dev_num * SWRM_MCP_SLV_STATUS_SZ));`
`541`	`541`
`542`	`542`	`if ((status & SWRM_MCP_SLV_STATUS_MASK) == SDW_SLAVE_ALERT) {`
`543`		`- ctrl->status[dev_num] = status;`
	`543`	`+ ctrl->status[dev_num] = status & SWRM_MCP_SLV_STATUS_MASK;`
`544`	`544`	`return dev_num;`
`545`	`545`	`}`
`546`	`546`	`}`