fix: mark password inputs with type="password" and autoComplete attributes#1048
Conversation
…butes Ensure the password field in login and signup forms is always rendered as an HTML password input (masked), and add appropriate autoComplete hints for browser password managers. Closes #1045 Co-authored-by: Aditya Choudhari <adityachoudhari26@users.noreply.github.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 40 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
There was a problem hiding this comment.
Pull request overview
Fixes the auth UI so password fields are always masked and provide correct autoComplete hints for browser password managers, addressing issue #1045.
Changes:
- Reordered props so
type="password"can’t be overridden by{...field}in login and signup forms. - Added
autoComplete="current-password"on login andautoComplete="new-password"on signup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/app/routes/auth/signup.tsx | Ensures signup password input is always type="password" and hints password managers with new-password. |
| apps/web/app/routes/auth/login.tsx | Ensures login password input is always type="password" and hints password managers with current-password. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensure the password field in login and signup forms is always rendered as an HTML password input (masked), and add appropriate autoComplete hints for browser password managers.
Changes:
type="password"to be placed after{...field}spread so it can never be overriddenautoComplete="current-password"to login andautoComplete="new-password"to signupCloses #1045
Generated with Claude Code