Skip to content

fix: mark password inputs with type="password" and autoComplete attributes#1048

Merged
adityachoudhari26 merged 1 commit intomainfrom
claude/issue-1045-20260423-1626
Apr 23, 2026
Merged

fix: mark password inputs with type="password" and autoComplete attributes#1048
adityachoudhari26 merged 1 commit intomainfrom
claude/issue-1045-20260423-1626

Conversation

@adityachoudhari26
Copy link
Copy Markdown
Member

Ensure the password field in login and signup forms is always rendered as an HTML password input (masked), and add appropriate autoComplete hints for browser password managers.

Changes:

  • Moved type="password" to be placed after {...field} spread so it can never be overridden
  • Added autoComplete="current-password" to login and autoComplete="new-password" to signup

Closes #1045

Generated with Claude Code

…butes

Ensure the password field in login and signup forms is always rendered
as an HTML password input (masked), and add appropriate autoComplete
hints for browser password managers.

Closes #1045

Co-authored-by: Aditya Choudhari <adityachoudhari26@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 16:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@adityachoudhari26 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 40 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 40 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5a622bd7-131b-45ce-bcbf-0d40153556f2

📥 Commits

Reviewing files that changed from the base of the PR and between 7414446 and 7a9c9d8.

📒 Files selected for processing (2)
  • apps/web/app/routes/auth/login.tsx
  • apps/web/app/routes/auth/signup.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-1045-20260423-1626

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adityachoudhari26 adityachoudhari26 merged commit a487ff6 into main Apr 23, 2026
9 of 10 checks passed
@adityachoudhari26 adityachoudhari26 deleted the claude/issue-1045-20260423-1626 branch April 23, 2026 16:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the auth UI so password fields are always masked and provide correct autoComplete hints for browser password managers, addressing issue #1045.

Changes:

  • Reordered props so type="password" can’t be overridden by {...field} in login and signup forms.
  • Added autoComplete="current-password" on login and autoComplete="new-password" on signup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/web/app/routes/auth/signup.tsx Ensures signup password input is always type="password" and hints password managers with new-password.
apps/web/app/routes/auth/login.tsx Ensures login password input is always type="password" and hints password managers with current-password.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login password field is not marked as an html password input, making the password visible

3 participants