fix: "false" is treated as valid CEL#1144
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates deployment selector formatting so the CEL expression "false" is preserved instead of being treated as absent.
Changes:
- Removes special-casing of
"false"in the deployment route selector parser. - Affects formatted deployment, job agent selector, and deployment variable selector responses in this route.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const parseSelector = (raw: string | null | undefined): string | undefined => { | ||
| if (raw == null || raw === "false") return undefined; | ||
| if (raw == null) return undefined; |
| if (raw == null) return undefined; | ||
| return raw; |
No description provided.