Skip to content

Stop propagation on the last cell of the TargetReleaseTable #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Stop propagation on the last cell of the TargetReleaseTable #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
843e47f
Stop propegation on the last cell
zacharyblasczyk Oct 24, 2024
5ad227d
fix
zacharyblasczyk Oct 24, 2024
5d6eb20
fix lint
zacharyblasczyk Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...ystems/[systemSlug]/deployments/[deploymentSlug]/releases/[versionId]/JobDropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ import {
} from "@ctrlplane/ui/tooltip";
import { activeStatus, JobStatus } from "@ctrlplane/validators/jobs";

import { useJobDrawer } from "~/app/[workspaceSlug]/_components/job-drawer/useJobDrawer";
import { api } from "~/trpc/react";

const overrideJobStatusFormSchema = z.object({
Expand Down Expand Up @@ -183,7 +182,6 @@ const ForceReleaseTargetDialog: React.FC<{
const forceRelease = api.release.deploy.toTarget.useMutation();
const router = useRouter();
const [open, setOpen] = useState(false);
const { setJobId } = useJobDrawer();

return (
<AlertDialog open={open} onOpenChange={setOpen}>
Expand Down Expand Up @@ -217,7 +215,6 @@ const ForceReleaseTargetDialog: React.FC<{
environmentId: environmentId,
isForcedRelease: true,
})
.then((rjt) => setJobId(rjt.jobId))
.then(() => router.refresh())
.then(() => setOpen(false))
.then(() => onClose())
Expand All @@ -240,7 +237,6 @@ const RedeployReleaseDialog: React.FC<{
const router = useRouter();
const redeploy = api.release.deploy.toTarget.useMutation();
const [isOpen, setIsOpen] = useState(false);
const { setJobId } = useJobDrawer();
return (
<Dialog open={isOpen} onOpenChange={setIsOpen}>
<DialogTrigger asChild>{children}</DialogTrigger>
Expand Down Expand Up @@ -268,8 +264,8 @@ const RedeployReleaseDialog: React.FC<{
targetId: target.id,
releaseId: release.id,
})
.then((rjt) => setJobId(rjt.jobId))
.then(() => router.refresh())
.then(() => setIsOpen(false))
}
>
Redeploy
Expand Down
2 changes: 1 addition & 1 deletion ...ems/[systemSlug]/deployments/[deploymentSlug]/releases/[versionId]/TargetReleaseTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export const TargetReleaseTable: React.FC<TargetReleaseTableProps> = ({
</div>
)}
</TableCell>
<TableCell>
<TableCell onClick={(e) => e.stopPropagation()}>
<div className="flex justify-end">
<JobDropdownMenu
release={release}
Expand Down
Loading