fix: Add tenant and subscription to aks cluster config

[adityachoudhari26]

Summary by CodeRabbit

• New Features

  • Azure Kubernetes configurations now require additional authentication details (tenant and subscription IDs) to enhance integration reliability.

• Refactor

  • Improved handling of Azure provider information in resource scanning to ensure more robust and consistent processing.

[coderabbitai]

Walkthrough

This change updates the way the convertManagedClusterToResource function is called and implemented. In the Azure resource scan logic, the function now receives the entire azureProvider object instead of destructuring the resourceProviderId. The update also modifies the function’s type signature and enriches the returned resource configuration by including additional authentication fields (tenantId and subscriptionId). Additionally, the Azure AKS configuration validation schema has been expanded to require these new properties.

Changes

File(s)	Summary of Changes
apps/event-worker/src/.../azure/aks.ts apps/event-worker/src/.../azure/cluster-to-resource.ts	Updated convertManagedClusterToResource signature to replace the providerId parameter with the full azureProvider object. In the implementation, the provider’s ID is now extracted from azureProvider, and auth is expanded with tenantId and subscriptionId.
packages/validators/src/.../kubernetes-v1.ts	Added tenantId and subscriptionId as new string properties in the Azure AKS method object within the clusterConfig schema, thereby updating the validation criteria.

Sequence Diagram(s)

sequenceDiagram
    participant Scanner as AKS Resource Scanner
    participant Converter as convertManagedClusterToResource
    Scanner ->> Converter: Call with (workspace.id, azureProvider, cluster, client)
    alt Process provider details
        Converter ->> Converter: Extract resourceProviderId, tenantId, subscriptionId from azureProvider
    end
    Converter -->> Scanner: Return resource with updated auth configuration

Loading

Possibly related PRs

• fix: Parse aks cluster cert info from kubeconfig #282: Updates the convertManagedClusterToResource signature to include an additional client parameter, establishing a direct relationship with the changes in this PR.

Suggested reviewers

• jsbroks

Poem

In my burrow of code beneath the moon's light,
I hopped through functions with sheer delight.
Passing full providers instead of fragments small,
Adding new keys to auth for one and all.
With a twitch of my whiskers, I code with glee—
A rabbit's joyful leap in our deep API!
🐇🌟 Happy coding to all!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b809e4 and e5112ef.

📒 Files selected for processing (3)

• apps/event-worker/src/resource-scan/azure/aks.ts (1 hunks)
• apps/event-worker/src/resource-scan/azure/cluster-to-resource.ts (3 hunks)
• packages/validators/src/resources/kubernetes-v1.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/event-worker/src/resource-scan/azure/aks.ts
• apps/event-worker/src/resource-scan/azure/cluster-to-resource.ts
• packages/validators/src/resources/kubernetes-v1.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Lint
• GitHub Check: build (linux/amd64)
• GitHub Check: build (linux/amd64)
• GitHub Check: Typecheck
• GitHub Check: build (linux/amd64)

🔇 Additional comments (6)

packages/validators/src/resources/kubernetes-v1.ts (1)

33-34: Schema properly updated with required Azure authentication fields.

The addition of tenantId and subscriptionId as required string fields in the Azure AKS authentication method is appropriate and aligns with Azure's authentication requirements. These fields will ensure that Azure AKS cluster configurations have complete authentication information.

apps/event-worker/src/resource-scan/azure/aks.ts (1)

50-55: Function call updated to pass the complete provider object.

The change correctly updates the convertManagedClusterToResource function call to pass the entire azureProvider object instead of just the resourceProviderId. This aligns with the updated function signature and allows access to the tenant and subscription IDs needed for the cluster configuration.

apps/event-worker/src/resource-scan/azure/cluster-to-resource.ts (4)

5-5: New import added for Azure provider schema.

The import of the SCHEMA module from @ctrlplane/db/schema correctly supports the updated function parameter type.

---

63-63: Function parameter updated to accept full provider object.

The parameter change from providerId: string to provider: SCHEMA.ResourceProviderAzure is appropriate and allows the function to access additional provider properties needed for authentication.

---

81-81: Resource provider ID reference updated.

The code correctly accesses the provider ID through the new parameter structure as provider.resourceProviderId.

---

88-94: Auth object enhanced with tenant and subscription IDs.

The auth object is properly expanded to include the tenant and subscription IDs from the provider object, aligning with the schema changes and ensuring complete authentication information is included in the cluster configuration.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.