fix: Optimize job fetching in release cell

[adityachoudhari26]

Summary by CodeRabbit

• Style

  • Refined spacing in deployment details for a more streamlined, compact layout.

• New Features

  • Introduced a dedicated display for job trigger details, including status messages and dynamic loading indicators.
  • Optimized the retrieval of job trigger data for a more responsive user experience.

[coderabbitai]

Walkthrough

This pull request introduces several focused changes. In the frontend, the padding for a table cell in the deployment page is reduced, and a new Message component is created to display job trigger information. The previous inline rendering and filtering logic related to job conditions are refactored in favor of using a more specific query. In the backend, a new API procedure (byReleaseAndEnvironmentId) is added to the job router to support the updated frontend queries. All modifications preserve existing functionality while streamlining the data retrieval and UI display processes.

Changes

File(s)	Change Summary
apps/webservice/src/app/[workspaceSlug]/.../DeploymentPageContent.tsx	Updated TableCell styling: changed className from px-3 py-2 to px-2 py-0, reducing padding.
apps/webservice/src/app/[workspaceSlug]/.../ReleaseInfo.tsx	Added a new Message component to render job trigger details, replaced inline rendering, and updated query usage from byWorkspaceId to byReleaseAndEnvironmentId.
packages/api/src/.../job.ts	Added a new protected procedure byReleaseAndEnvironmentId for querying job triggers by release and environment, including input validation, authorization, join with job data, and pagination.

Sequence Diagram(s)

sequenceDiagram
    participant UI as ReleaseInfo Component
    participant Msg as Message Component
    participant JobAPI as Job Config API (byReleaseAndEnvironmentId)
    participant ResAPI as Resource API (byId)

    UI ->> JobAPI: Query job triggers (using releaseId & environmentId)
    JobAPI -->> UI: Return job trigger list
    UI ->> Msg: Render details for each trigger
    Msg ->> ResAPI: Fetch resource details for trigger.resourceId
    ResAPI -->> Msg: Return resource data
    Msg -->> UI: Display job message with resource info

Loading

Possibly related PRs

• fix: Consolidate cell styles #369: Similar modifications to TableCell components adjusting padding and layout.
• fix: Scrolling issues on deployment pages #345: Also involves styling adjustments in deployment components, with a focus on UI presentation.

Suggested reviewers

• jsbroks

Poem

I'm a coding rabbit, soft pads now light,
Hopping through changes in the soft twilight.
A new Message springs from the burrow so neat,
With API paths and queries in a rhythmic beat.
Hop along, dear devs, with joy so bright! 🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9ccde9 and 6f9929b.

📒 Files selected for processing (3)

• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/DeploymentPageContent.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/_components/deployments/environment-cell/ReleaseInfo.tsx (6 hunks)
• packages/api/src/router/job.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• packages/api/src/router/job.ts
• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/DeploymentPageContent.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/_components/deployments/environment-cell/ReleaseInfo.tsx

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Typecheck
• GitHub Check: Lint
• GitHub Check: build (linux/amd64)

🔇 Additional comments (10)

apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/DeploymentPageContent.tsx (1)

344-344: Refined UI spacing in table cell.

The padding reduction in the TableCell (from the previous px-3 py-2 to px-2 py-0) creates a more compact layout, allowing for better space utilization in the deployments UI.

packages/api/src/router/job.ts (1)

435-473: Well-implemented specialized query procedure.

This new byReleaseAndEnvironmentId procedure efficiently retrieves job triggers specific to a release and environment combination. The implementation follows the established patterns in this file:

1. Proper input validation with appropriate constraints
2. Correct authorization checks using environment ID
3. Efficient query with appropriate joins and filters
4. Clean result transformation for frontend consumption

This targeted query will improve performance by eliminating the need to fetch and filter data client-side.

apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/_components/deployments/environment-cell/ReleaseInfo.tsx (8)

1-2: Improved type imports.

The code now imports specific types from the schema and validators, which helps with code clarity and potentially improves build performance through more targeted imports.

---

16-16: Added Skeleton component import for loading states.

The Skeleton component is now properly imported to support the loading states in the new Message component.

---

23-23: Added import for activeStatusType.

Importing activeStatusType from the jobs validators to properly check for active job statuses.

---

34-52: Good component extraction for improved modularity.

The new Message component effectively encapsulates the logic for displaying job trigger information. It:

1. Accepts a trigger prop with the necessary data
2. Fetches resource information using the resource ID
3. Shows appropriate loading states
4. Displays status and message information in a consistent format

This extraction improves code organization and reusability.

---

77-79: Optimized data fetching with specialized query.

Replacing the previous implementation with the new targeted query procedure:

• Reduces data transferred over the network
• Simplifies client-side filtering logic
• Provides more predictable performance

This change aligns well with the PR objective of optimizing job fetching.

---

84-84: Updated grouping logic to use resourceId directly.

The code now groups by resourceId directly instead of resource.id, which is consistent with the data structure returned by the new query.

---

102-102: Simplified message presence check.

The code now directly checks for the presence of d.job.message which is cleaner and more direct than the previous implementation.

---

147-147: Replaced inline rendering with Message component.

Using the new Message component here improves code readability and maintainability by encapsulating the presentation logic in a dedicated component.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.