fix: Init release channel to dep vers channel frontend refactor #383
Conversation
WalkthroughThis pull request systematically renames and refactors many components, hooks, variables, and types across the codebase. The changes replace “ReleaseChannel” terminology with “DeploymentVersionChannel” in UI components, dialogs, tables, pages, drawers, and hooks. The refactoring affects import statements, function names, component signatures, and enum members, ensuring consistency in naming conventions throughout the application without altering the underlying business logic. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Tab as TabButton (DeploymentVersionChannels)
participant Drawer as EnvironmentDrawer
participant Page as DeploymentVersionChannels Component
User->>Tab: Click "DeploymentVersionChannels" tab
Tab->>Drawer: Notify active tab change
Drawer->>Page: Render DeploymentVersionChannels component
Page-->>User: Display deployment version channel info
Possibly related PRs
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsx (1)
40-42: 💡 Verification agent🧩 Analysis chain
Potential inconsistency in prop naming
While the type is correctly using
SCHEMA.DeploymentVersionChannel, the prop name is stillreleaseChannel. Consider renaming this prop todeploymentVersionChannelfor complete consistency with the PR's renaming objective.
🏁 Script executed:
#!/bin/bash # Check if other components in the codebase have been updated to use the new prop name rg -A 1 -B 1 "releaseChannel: SCHEMA\.DeploymentVersionChannel" --type ts --type tsxLength of output: 114
🏁 Script executed:
#!/bin/bash # Re-run the search using file globs instead of the --type flag to properly include TSX files. rg -g "*.tsx" -g "*.ts" "releaseChannel: SCHEMA\.DeploymentVersionChannel" -n -A 1 -B 1Length of output: 433
Rename Prop for Consistency
In the file
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsxat lines 40–42, the prop is still namedreleaseChanneleven though its type is updated toSCHEMA.DeploymentVersionChannel. To maintain naming consistency with the updated schema and the PR's objectives, please rename the prop fromreleaseChanneltodeploymentVersionChannel.apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx (1)
40-41: 💡 Verification agent🧩 Analysis chain
URL parameters still use "release_channel_id".
The URL parameters in the
deleteParamsfunction still use the old naming convention. If this is a comprehensive renaming effort, these might need to be updated as well, though this depends on whether the corresponding URL handling code has been updated.Check if URL parameter handling has been updated elsewhere:
🏁 Script executed:
#!/bin/bash # Check for other instances of URL parameters using release_channel_id rg "release_channel_id" --type ts --type tsxLength of output: 72
Verify Comprehensive URL Parameter Update
The code in
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx(lines 40-41) still deletes URL parameters named"release_channel_id"and"release_channel_id_filter". This indicates that while some renaming efforts might be underway, this function is still using the old naming convention.Since the initial search using:
rg "release_channel_id" --type ts --type tsxfailed due to
tsxnot being a recognized file type, please re-run the above corrected command to confirm whether there are any other instances of the old parameter naming in the codebase.If the updated search confirms that no other parts use the outdated parameter name, then this might be an isolated case. Otherwise, you'll need to update these lines to match the new naming convention if the corresponding URL handling code has been updated.
🏁 Script executed:
#!/bin/bash # Re-run the search for "release_channel_id" in .ts and .tsx files using explicit glob patterns rg release_channel_id -g '*.ts' -g '*.tsx'Length of output: 672
Rename URL Parameters for Consistency
The code in
DeploymentVersionChannelDropdown.tsx(lines 40-41) still deletes URL parameters named"release_channel_id"and"release_channel_id_filter". Our search confirmed that:
- In
useDeploymentVersionChannelDrawer.ts, the parameter"release_channel_id"is still used.- In
useReleaseFilter.ts, the constantreleaseChannelParamis set to"release_channel_id_filter".If a comprehensive renaming effort is intended, please update all corresponding references (including URL creation and handling in these files) to ensure consistency across the codebase. Verify that any related backend processes or URL handling logic are aligned with the new naming convention.
🧹 Nitpick comments (5)
apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/JobDropdownMenu.tsx (1)
340-340: Tooltip text still references old terminology.While the prop has been renamed to
isPassingDeploymentVersionChannel, the tooltip message still uses "Release channel does not match filter" instead of "Deployment version channel does not match filter".- Release channel does not match filter + Deployment version channel does not match filterapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/CreateDeploymentVersionChannelDialog.tsx (1)
112-112: Update dialog title to match new component nameThe component has been renamed to
DeploymentVersionChannelDialog, but the dialog title still displays "Create Release Channel". For consistency with the refactoring efforts across the codebase, consider updating this text.- <DialogTitle>Create Release Channel</DialogTitle> + <DialogTitle>Create Deployment Version Channel</DialogTitle>apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsx (1)
23-24: Rename remaining variable for consistencyWhile the hook has been renamed to
useDeploymentVersionChannelDrawer, one of the destructured variables is still namedreleaseChannelIdinstead ofdeploymentVersionChannelId. This inconsistency might lead to confusion.- const { releaseChannelId, removeDeploymentVersionChannelId } = - useDeploymentVersionChannelDrawer(); + const { deploymentVersionChannelId, removeDeploymentVersionChannelId } = + useDeploymentVersionChannelDrawer();You'll need to update all references to
releaseChannelIdin this file as well, such as on lines 25, 26, 28, 29.apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/release-cell/ReleaseEnvironmentCell.tsx (1)
192-193: Update UI text to match refactored terminologyFor consistency with the codebase renaming effort, the UI text should refer to "deployment version channel" instead of "release channel".
- release channel + deployment version channelapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx (1)
67-68: Dialog title text still refers to "release channel".While component names have been updated throughout the file, the AlertDialogTitle text still refers to "release channel" rather than "deployment version channel".
Consider updating the text for consistency:
- Are you sure you want to delete this release channel? + Are you sure you want to delete this deployment version channel?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/checks/_components/flow-diagram/EnvironmentNode.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/DeploymentCTA.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/release-cell/ReleaseEnvironmentCell.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/CreateDeploymentVersionChannelDialog.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/DeploymentVersionChannelsTable.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/page.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx(7 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/page.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx(5 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.ts(1 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/EnvironmentDrawer.tsx(1 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/policy-override/UpdateOverride.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/tabs.ts(1 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/JobDropdownMenu.tsx(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/drawer/JobDrawer.tsx(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/drawer/EnvironmentPolicyDrawer.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsx(7 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/ReleaseConditionDialog.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.ts(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/layout.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...
**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/DeploymentCTA.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/EnvironmentDrawer.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/checks/_components/flow-diagram/EnvironmentNode.tsxapps/webservice/src/app/[workspaceSlug]/(app)/layout.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/policy-override/UpdateOverride.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/ReleaseConditionDialog.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/job/drawer/JobDrawer.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/release-cell/ReleaseEnvironmentCell.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/page.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.tsapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/page.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/tabs.tsapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/CreateDeploymentVersionChannelDialog.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/job/JobDropdownMenu.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.tsapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/DeploymentVersionChannelsTable.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/drawer/EnvironmentPolicyDrawer.tsx
🧠 Learnings (4)
apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/EnvironmentDrawer.tsx (2)
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/environment-drawer/EnvironmentDrawer.tsx:139-154
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `EnvironmentDrawer.tsx`, for the `EnvironmentDrawer` component, when there are only a few `TabButton` instances (e.g., 3), it's acceptable to define them individually without extracting them into a configuration to reduce repetition.
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx:42-44
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx`, within the `Usage` component, the arrays used for filtering inherited environments are expected to remain small. Therefore, performance optimizations for this filtering logic are not necessary.
apps/webservice/src/app/[workspaceSlug]/(app)/layout.tsx (4)
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/environment-drawer/EnvironmentDrawer.tsx:139-154
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `EnvironmentDrawer.tsx`, for the `EnvironmentDrawer` component, when there are only a few `TabButton` instances (e.g., 3), it's acceptable to define them individually without extracting them into a configuration to reduce repetition.
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#183
File: apps/webservice/src/app/[workspaceSlug]/_components/environment-drawer/EnvironmentDrawer.tsx:55-57
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `EnvironmentDrawer.tsx`, we prefer to fetch all data upfront and show a loading indicator until everything is fetched, unless performance becomes an issue.
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx:42-44
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx`, within the `Usage` component, the arrays used for filtering inherited environments are expected to remain small. Therefore, performance optimizations for this filtering logic are not necessary.
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#183
File: apps/webservice/src/app/[workspaceSlug]/_components/environment-drawer/ReleaseChannels.tsx:48-71
Timestamp: 2025-03-14T19:06:31.548Z
Learning: Prefer using `Object.fromEntries` over `.reduce` for transforming arrays into objects in React components to improve readability and maintainability.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/drawer/JobDrawer.tsx (1)
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx:42-44
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx`, within the `Usage` component, the arrays used for filtering inherited environments are expected to remain small. Therefore, performance optimizations for this filtering logic are not necessary.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx (1)
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx:42-44
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx`, within the `Usage` component, the arrays used for filtering inherited environments are expected to remain small. Therefore, performance optimizations for this filtering logic are not necessary.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (linux/amd64)
- GitHub Check: Typecheck
- GitHub Check: Lint
🔇 Additional comments (67)
apps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/ReleaseConditionDialog.tsx (1)
61-62: Consistent renaming of state variablesThe renaming from
localReleaseChannelIdtolocalDeploymentVersionChannelIdhas been implemented consistently across all usage points, reflecting the broader refactoring effort to standardize terminology throughout the codebase.Note: While the state variable has been renamed, there are still references to "release channels" in other parts of the component (UI text, prop names, and variables). This mixed terminology might cause confusion for future developers. Consider addressing these in a follow-up PR for complete consistency.
Also applies to: 92-92, 111-111, 117-117, 141-141, 146-146, 151-151
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsx (5)
102-103: Renaming follows PR objectiveThe variable renaming from
updateReleaseChanneltoupdateDeploymentVersionChannelaligns with the PR objective to systematically replace "ReleaseChannel" terminology with "DeploymentVersionChannel" throughout the codebase.
106-107: Consistent update of renamed variableThe variable usage has been correctly updated in the
onSubmitfunction to use the renamedupdateDeploymentVersionChannelmutation.
190-193: Consistent update in Button's disabled propertyThe renamed variable is correctly used in the Button component's disabled property logic.
109-111:✅ Verification successful
API path inconsistency
The invalidation path still uses
releaseChannel.byId. If API paths have been refactored as part of this PR, this should be updated todeploymentVersionChannel.byIdfor consistency.
🏁 Script executed:
#!/bin/bash # Check if the API paths have been refactored in this PR rg "deployment\.releaseChannel" --type ts --type tsx rg "deployment\.deploymentVersionChannel" --type ts --type tsxLength of output: 175
I'm going to re-run the search using updated glob patterns to correctly include TypeScript and TSX files. Please execute the following shell script:
This will help verify whether the API path has been refactored from
releaseChannel.byIdtodeploymentVersionChannel.byId.
🏁 Script executed:
#!/bin/bash # Re-run search over .ts and .tsx files using glob patterns rg "deployment\.releaseChannel" -g "*.ts" -g "*.tsx" rg "deployment\.deploymentVersionChannel" -g "*.ts" -g "*.tsx"Length of output: 2412
Confirmed API Usage Consistency
After verifying the repository with additional searches, it appears that all API references consistently usedeployment.releaseChannel(including within files likeOverview.tsx). There is no trace of adeploymentVersionChannelendpoint in the current codebase; therefore, updating the invalidation path todeploymentVersionChannel.byIdis not required.
60-61:❓ Verification inconclusive
URL parameter naming inconsistency
The URL parameter is still using
release-channel-idin the query string. If URL parameters have been refactored across the codebase, consider updating this todeployment-version-channel-idfor consistency.
🏁 Script executed:
#!/bin/bash # Check if URL parameters have been updated in other components rg "release-channel-id" --type ts --type tsx rg "deployment-version-channel-id" --type ts --type tsxLength of output: 156
I'm noticing that the original search produced errors because the file type "tsx" isn't recognized by ripgrep with the
--typeflag. To ensure we capture our search targets correctly, let's re-run the verification using glob patterns instead. Please execute the following updated shell script to search for both the old parameter (release-channel-id) and the new one (deployment-version-channel-id) across both TS and TSX files:#!/bin/bash echo "Searching for 'release-channel-id' in TSX files:" rg 'release-channel-id' -g '*.tsx' echo "Searching for 'release-channel-id' in TS files:" rg 'release-channel-id' -g '*.ts' echo "Searching for 'deployment-version-channel-id' in TSX files:" rg 'deployment-version-channel-id' -g '*.tsx' echo "Searching for 'deployment-version-channel-id' in TS files:" rg 'deployment-version-channel-id' -g '*.ts'Once we have the results from these commands, we can definitively decide whether a refactor is needed in the
Overview.tsxfile. Please run the script and share the output to continue the verification process.apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/tabs.ts (1)
7-7: Enum member rename looks good!The rename from
ReleaseChannelstoDeploymentVersionChannelsis consistent with the broader refactoring effort while maintaining the same string value ("release-channels"), which helps preserve backward compatibility with existing URLs or database references.apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/page.tsx (2)
2-2: Import statement updated correctlyThe import statement has been properly updated to use the new
DeploymentVersionChannelscomponent.
19-22: Component usage updated consistentlyThe component usage has been updated to match the new name while maintaining the same props structure, which is good for backward compatibility.
apps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.ts (4)
13-13: Hook name updated correctlyThe hook name has been properly updated from
useReleaseChanneltouseDeploymentVersionChannel.
20-24: Variable names updated consistentlyThe variable names have been updated to follow the new naming convention while maintaining the same logic.
46-54: Boolean variable names updated consistentlyAll the boolean variables have been properly renamed to match the new terminology.
56-56:❓ Verification inconclusive
Verify if
releaseChannelIdshould be renamedWhile most variables have been renamed to use the "DeploymentVersionChannel" terminology,
releaseChannelIdin the return object remains unchanged. Consider whether this should also be renamed todeploymentVersionChannelIdfor consistency.
🏁 Script executed:
#!/bin/bash # Search for usages of the hook to verify if the returned releaseChannelId is used elsewhere echo "Searching for usages of useDeploymentVersionChannel..." rg -A 3 "useDeploymentVersionChannel" --glob "*.{ts,tsx}" echo "Checking if releaseChannelId is used in other files..." rg "releaseChannelId" --glob "*.{ts,tsx}" | grep -v "useDeploymentVersionChannel.ts"Length of output: 19569
Inconsistent Naming – Verify Impact Before Renaming
The hook currently returns an object with a property named
releaseChannelId, yet the hook’s name and several related functions (e.g.,setDeploymentVersionChannelIdandremoveDeploymentVersionChannelId) use “DeploymentVersionChannel.” The repository search confirms that many consumer files (such as in the drawers, release condition components, and even some API routers) still referencereleaseChannelId. Changing this property in the hook would require updating all consuming code to maintain consistency and avoid potential breakage.
File to update:
apps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.ts(line 56)Action items:
- If you decide to rename the property to
deploymentVersionChannelId, verify that all components and hooks that destructure or use this value (e.g., in EnvironmentNode.tsx, JobDrawer.tsx, and the various channel drawer components) are updated accordingly.- Ensure the change does not inadvertently break any API expectations—especially since some backend files (in
packages/api) also refer toreleaseChannelId.Please review the dependent usages before applying a global rename.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.ts (5)
5-5: Hook name updated correctlyThe hook name has been properly updated from
useReleaseChannelDrawertouseDeploymentVersionChannelDrawer.
10-15: Function name updated correctlyThe function has been properly renamed from
setReleaseChannelIdtosetDeploymentVersionChannelIdwhile maintaining the same functionality.
17-18: Helper function updated consistentlyThe helper function has been properly renamed and updated to call the renamed setter function.
3-3:❓ Verification inconclusive
Consider updating the URL parameter name
The URL parameter name
release_channel_idremains unchanged. While keeping it the same maintains backward compatibility with existing URLs, consider if it should be updated to match the new terminology or if there's a reason to keep it as is.
🏁 Script executed:
#!/bin/bash # Check if the parameter is used in other files or components echo "Searching for usages of release_channel_id parameter..." rg "release_channel_id" --glob "*.{ts,tsx}" | grep -v "useDeploymentVersionChannelDrawer.ts"Length of output: 693
Action: Revisit URL Parameter Naming Consistency
It appears that the parameter
"release_channel_id"—defined inuseDeploymentVersionChannelDrawer.ts—is also used in other components (for example, it’s being deleted inDeploymentVersionChannelDropdown.tsx), and a similar parameter ("release_channel_id_filter") is found inuseReleaseFilter.ts. If you're considering adopting new naming terminology, please ensure that all instances are updated consistently or document why some components intentionally use a slightly different name.
20-24:❓ Verification inconclusive
Consider updating the property name in the return object
While the function names have been updated, the return object still uses
releaseChannelIdas a property name. Consider updating this todeploymentVersionChannelIdfor complete consistency in the refactoring.
🏁 Script executed:
#!/bin/bash # Check where this returned property is used echo "Searching for places where the returned releaseChannelId is used..." rg "const \{.*releaseChannelId.*\} = useDeploymentVersionChannelDrawer\(\)" --glob "*.{ts,tsx}"Length of output: 242
Action Required: Update the returned property name for consistency
After re-checking the usage of the
releaseChannelIdproperty with the provided search script (which returned no results), it's still advisable to rename this property todeploymentVersionChannelIdto match the updated function names. Please ensure that this change won’t affect any usage in parts of the codebase that might refer to it. Manual verification is recommended to confirm that no unexpected dependencies exist on the old property name.
- File:
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.ts, Lines 20-24- Change: Rename
releaseChannelIdtodeploymentVersionChannelIdin the returned objectapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/DeploymentCTA.tsx (1)
9-9: Correctly updated component names to match new terminology.The imports and component usage have been updated from
CreateReleaseChannelDialogtoCreateDeploymentVersionChannelDialog, which aligns with the PR's objective of renaming ReleaseChannel to DeploymentVersionChannel.Also applies to: 30-34
apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/JobDropdownMenu.tsx (1)
290-290: Consistently renamed the prop for clarity.The prop has been properly renamed from
isPassingReleaseChanneltoisPassingDeploymentVersionChannelin the component interface and implementation.Also applies to: 298-298, 327-327, 346-346
apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/EnvironmentDrawer.tsx (2)
179-184: Updated tab enum references.The tab checking and setting logic has been updated from
EnvironmentDrawerTab.ReleaseChannelstoEnvironmentDrawerTab.DeploymentVersionChannels, keeping the implementation consistent with the enum changes.
186-186: UI label remains as "Release Channels".While internal code uses the new "DeploymentVersionChannels" terminology, the user-facing label still displays "Release Channels". This might be intentional for maintaining a familiar UI, but should be verified for consistency with the overall renaming effort.
Is this a deliberate decision to keep the user-facing label as "Release Channels" while updating the internal code references to "DeploymentVersionChannels"?
apps/webservice/src/app/[workspaceSlug]/(app)/layout.tsx (1)
6-6: Updated drawer component name.The import and usage of
ReleaseChannelDrawerhave been correctly updated toDeploymentVersionChannelDrawer, maintaining consistency with the renaming across the codebase.Also applies to: 62-62
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/checks/_components/flow-diagram/EnvironmentNode.tsx (4)
27-28: Imports updated correctly to use deployment version channel hooks.The import paths have been properly updated to reflect the renamed hooks in the codebase.
135-142: Component renamed with proper prop typing preserved.The component has been renamed from
ReleaseChannelChecktoDeploymentVersionChannelCheckwhile preserving the correct prop typing. The hook usage has been updated accordingly to use the renamed hooks.
152-185: Consistent variable naming throughout component render logic.All instances of variables and function calls have been properly renamed, maintaining the same logical conditions but with updated terminology.
272-272: Component reference updated in parent component.The reference to the renamed component has been properly updated in the
EnvironmentNodecomponent.apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx (4)
39-39: Import path updated for the renamed hook.The import has been correctly updated to use the new hook name in the updated location.
136-137: Renamed variable while preserving loading variable name.The hook usage has been updated to destructure
isPassingDeploymentVersionChannelinstead ofisPassingReleaseChannel, while wisely preserving thereleaseChannelLoadingvariable name to minimize changes to dependent code.
315-317: Prop name updated in JobDropdownMenu component.The prop name has been updated to match the renamed variable while preserving the same functionality.
422-424: Consistent prop renaming in nested component instance.The same prop has been correctly renamed in the nested instance of JobDropdownMenu within the CollapsibleContent section.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/drawer/JobDrawer.tsx (3)
16-16: Import path updated correctly.The import has been properly updated to use the renamed hook.
42-48: Updated hook usage while preserving function behavior.The hook has been renamed and the destructured variable has been updated to
isPassingDeploymentVersionChannel, while maintaining the same loading variable name and passing the same parameters to the hook.
78-80: Updated prop name passed to JobDropdownMenu.The prop name has been correctly updated to match the renamed variable.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/policy-override/UpdateOverride.tsx (2)
6-6: Import updated to use renamed component.The import has been properly updated to use the renamed component.
61-62: Updated conditional rendering and component reference.The condition has been updated to check for the renamed tab enum value, and the component reference has been updated to use the renamed component.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/page.tsx (1)
24-29: LGTM!The page component has been successfully updated to use the new
DeploymentVersionChannelsTablecomponent, maintaining compatibility with the API responses through the existing variable names.apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/drawer/EnvironmentPolicyDrawer.tsx (4)
29-29: LGTM: Import statement properly updated.The import statement is correctly updated to import the renamed DeploymentVersionChannels component, which is part of the broader renaming effort in this PR.
42-42: LGTM: Enum value renamed while preserving original string value.The enum value has been renamed from ReleaseChannels to DeploymentVersionChannels while preserving the original string value "release-channels". This ensures backward compatibility with existing URL parameters and stored values.
159-160: LGTM: Component reference updated in conditional rendering.The conditional check and component rendering have been properly updated to use the new DeploymentVersionChannels component name.
244-249: LGTM: Tab button logic updated to use new enum value.The tab button's active state check and onClick handler have been updated to reference the renamed DeploymentVersionChannels enum value, maintaining consistent functionality.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/DeploymentVersionChannelsTable.tsx (5)
15-15: LGTM: Updated import statement correctly.The import is properly updated to use the renamed hook useDeploymentVersionChannelDrawer.
18-20: LGTM: Type definition properly renamed.The type has been renamed from ReleaseChannel to DeploymentVersionChannel, maintaining the same structure and property set.
22-24: LGTM: Props type renamed appropriately.The props type has been renamed to DeploymentVersionChannelTableProps, preserving the same data structure.
26-30: LGTM: Component and hook usage properly renamed.The component has been renamed to DeploymentVersionChannelsTable and correctly uses the setDeploymentVersionChannelId function from the hook.
45-45: LGTM: Click handler updated consistently.The onClick handler has been updated to use setDeploymentVersionChannelId, maintaining the same functionality.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsx (8)
25-28: LGTM: Function renamed consistently in prop type.The function has been properly renamed from updateReleaseChannel to updateDeploymentVersionChannel in the DeploymentSelectProps type definition.
34-34: LGTM: Function references updated in component implementation.The function prop name and its usage in the onChange handler have been properly updated to the new naming convention.
Also applies to: 43-43
50-52: LGTM: Variable appropriately renamed.The variable has been renamed from sortedReleaseChannels to sortedDeploymentVersionChannels while maintaining the same sorting logic.
75-75: LGTM: Updated variable usage in conditional rendering.References to the renamed variable have been consistently updated in the conditional rendering logic.
Also applies to: 85-86
113-113: LGTM: Type and component properly renamed.The type DeploymentVersionChannelProps and component DeploymentVersionChannels are properly renamed while preserving the same interface.
Also applies to: 120-122
123-123: LGTM: Variable names consistently updated.All variables related to deployment version channels have been renamed while maintaining the same functionality and data structure.
Also applies to: 128-133
135-144: LGTM: Function renamed while preserving implementation details.The updateDeploymentVersionChannel function has been renamed and its implementation has been updated to reference the new variable names.
161-162: LGTM: Props correctly passed to child component.The props passed to DeploymentSelect have been updated to use the new variable and function names.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx (8)
25-28: LGTM: Function renamed consistently in prop type.The function has been properly renamed from updateReleaseChannel to updateDeploymentVersionChannel in the type definition.
34-34: LGTM: Function references updated in component implementation.The function prop name and its usage in the onChange handler have been properly updated.
Also applies to: 43-43
50-52: LGTM: Variable appropriately renamed.The variable has been renamed from sortedReleaseChannels to sortedDeploymentVersionChannels while preserving the same functionality.
75-75: LGTM: Updated variable usage in conditional rendering.References to the renamed variable have been consistently updated in the rendering logic.
Also applies to: 85-86
113-113: LGTM: Type and component properly renamed.The type and component have been renamed to DeploymentVersionChannelProps and DeploymentVersionChannels respectively.
Also applies to: 118-120
123-123: LGTM: Variable names consistently updated.All variables related to deployment version channels have been properly renamed.
Also applies to: 128-133
135-144: LGTM: Function renamed while preserving implementation details.The updateDeploymentVersionChannel function has been renamed and its implementation has been updated accordingly.
166-167: LGTM: Props correctly passed to child component.The props passed to DeploymentSelect have been updated to use the new variable and function names.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx (5)
78-78: Consistent usage of renamed mutation function.The
isPendingproperty reference has been correctly updated to use the renamed mutation function.
89-96: Component and type names successfully renamed, maintaining consistent naming pattern.The type
ReleaseChannelDropdownPropshas been renamed toDeploymentVersionChannelDropdownProps, and the component has been renamed accordingly, maintaining the consistent renaming pattern throughout the file.
102-113: Renamed dialog component used consistently.The
DeleteDeploymentVersionChannelDialogcomponent is correctly referenced in place of the previousDeleteReleaseChannelDialog.
46-53:❓ Verification inconclusive
Mutation function name updated but API endpoint path remains unchanged.
The mutation function has been renamed from
deleteReleaseChanneltodeleteDeploymentVersionChannel, while the API endpoint it calls (api.deployment.releaseChannel.delete) still uses the old naming convention. This might be intentional if the backend API hasn't been updated yet.Check if this is part of a phased approach where UI components are renamed before API endpoints:
🏁 Script executed:
#!/bin/bash # Check the API definition to see if there are plans to rename the endpoint rg "releaseChannel.delete" --type tsLength of output: 202
Action Required: Confirm Phased API Renaming
The UI now uses the updated mutation function name (
deleteDeploymentVersionChannel), but the API call still referencesreleaseChannel.delete. Thergoutput confirms that this endpoint remains unchanged in the codebase. Please verify with the backend team or product requirements to ensure this is an intentional phased renaming.
26-34:❓ Verification inconclusive
Type and component names successfully renamed, but prop names remain unchanged.
The type
DeleteReleaseChannelDialogPropshas been correctly renamed toDeleteDeploymentVersionChannelDialogProps, and the component has been updated accordingly. However, the prop namereleaseChannelIdremains unchanged, which creates some inconsistency in naming conventions.Consider whether all references should be updated for complete consistency:
🏁 Script executed:
#!/bin/bash # Check if there are other instances where props or variables haven't been renamed rg "releaseChannelId" --type ts --type tsxLength of output: 70
Revised Comment – Prop Naming Consistency Check
Type and component names have been successfully updated to use the new “DeploymentVersionChannel” naming. However, the prop name still uses “releaseChannelId,” which is inconsistent with the updated conventions. To be fully consistent, please consider renaming this prop (for example, to something like “deploymentVersionChannelId”) if it aligns with your broader naming scheme.
Note: The initial search for “releaseChannelId” using
rg "releaseChannelId" --type ts --type tsxfailed due to TSX file type recognition. An updated search using TSX file extension support (e.g.,
rg "releaseChannelId" --type-add "tsx:*.tsx" --type ts --type tsx ```) is recommended to verify that no other unintended references remain. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx (1)
78-82: 💡 Verification agent🧩 Analysis chain
URL path and UI text inconsistency.
The URL path still contains "release-channels" and the button text still refers to "Create release channel" while the code has been updated to use the new terminology.
🏁 Script executed:
#!/bin/bash # Check if the routes have been updated to match the new terminology rg -A 3 -B 3 "release-channels" --glob "*.ts*"Length of output: 12409
Fix URL and UI text to align with new deployment version channels terminology
- In the file
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx(lines 78-82), the link still uses the old path/release-channelsand text "Create release channel". Since the file name and overall naming have moved to "deployment version channels," please update the URL (e.g., change it to something like/deployment-version-channels) and the button text (e.g., "Create deployment version channel") to match the new terminology.- Also, review similar occurrences in related components (e.g., in
_components/policy/drawer/EnvironmentPolicyDrawer.tsxand_components/environment/drawer/tabs.ts) for consistency across the application.apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsx (1)
78-82: 💡 Verification agent🧩 Analysis chain
URL path and UI text inconsistency.
The URL path still contains "release-channels" and the button text still refers to "Create release channel" while the code has been updated to use the new terminology.
🏁 Script executed:
#!/bin/bash # Check if the routes have been updated to match the new terminology rg -A 3 -B 3 "release-channels" --glob "*.ts*"Length of output: 12409
Action Required: Update URL Route and Button Label to New Terminology
It appears that the outdated term "release-channels" is still being used in both the URL and the button text. Please update the following:
- URL Path: Change the segment from
/deployments/${deployment.slug}/release-channelsto the new, standardized term as defined in the updated naming convention.- Button Text: Update "Create release channel" to reflect the new terminology.
These changes should be applied consistently across the codebase (e.g., related API endpoints and other UI elements) to ensure coherent usage of the new naming convention.
🧹 Nitpick comments (18)
packages/job-dispatch/src/policies/release-sequencing.ts (1)
93-107: Consider renaming the variable and alias for consistencyWhile all schema references have been correctly updated from
environmentPolicyReleaseChanneltoenvironmentPolicyDeploymentVersionChannel, the local variablereleaseChannelSubquery(line 91) and its alias "release_channel" (line 110) still use the old terminology. Consider renaming these for complete consistency with the rest of the changes.-const releaseChannelSubquery = db +const deploymentVersionChannelSubquery = db .select({ rcPolicyId: schema.environmentPolicyDeploymentVersionChannel.policyId, rcReleaseFilter: schema.deploymentVersionChannel.versionSelector, }) .from(schema.environmentPolicyDeploymentVersionChannel) .innerJoin( schema.deploymentVersionChannel, eq( schema.environmentPolicyDeploymentVersionChannel.channelId, schema.deploymentVersionChannel.id, ), ) .where( eq( schema.environmentPolicyDeploymentVersionChannel.deploymentId, release.deploymentId, ), ) - .as("release_channel"); + .as("deployment_version_channel");And update the reference on line 121 accordingly.
apps/webservice/src/app/api/v1/release-channels/route.ts (1)
25-41: Error message still references "Release channel"While the variable has been renamed from
releaseChanneltodeploymentVersionChannel, the error message on line 40 still refers to "Release channel already exists". Consider updating the error message for complete consistency.if (deploymentVersionChannel) return NextResponse.json( { - error: "Release channel already exists", + error: "Deployment version channel already exists", id: deploymentVersionChannel.id, }, { status: 409 }, );Also, note that the route file path itself still contains "release-channels". This might be intentional for backward compatibility of the API endpoints.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/resource-drawer/DeploymentResourceDrawer.tsx (1)
49-52: Refactoring: Consider updating variable name in line 51 for consistency.The renaming from
releaseChannelstoversionChannelsis good, but the lambda parameterrc(release channel) on line 51 still uses the old terminology, making the code less self-documenting.const { versionSelector } = environment?.policy.versionChannels.find( - (rc) => rc.deploymentId === deploymentId, + (versionChannel) => versionChannel.deploymentId === deploymentId, ) ?? {};apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/page.tsx (1)
15-15: Consider updating search param name for full consistency.While you've updated variable names from
releaseChanneltodeploymentVersionChannel, the search parameter name"release-channel-id"remains unchanged. This creates a disconnect between the URL parameter and the variable name.For complete consistency, consider updating the search parameter definition and usage:
- searchParams: Promise<{ "release-channel-id"?: string }>; + searchParams: Promise<{ "deployment-version-channel-id"?: string }>;And then updating the usage:
- const deploymentVersionChannel = searchParams["release-channel-id"] + const deploymentVersionChannel = searchParams["deployment-version-channel-id"]Note: This would require additional changes to any code that generates URLs with this parameter.
Also applies to: 38-42
apps/webservice/src/app/api/v1/environments/route.ts (1)
72-72: Terminology inconsistency between request and database fields.The request body uses
deploymentVersionChannelsbut thecreateEnvfunction usesversionChannels. This inconsistency could lead to confusion for developers.Consider standardizing the terminology either by:
- Using
deploymentVersionChannelsconsistently:- versionChannels: channels, + deploymentVersionChannels: channels,
- Or by using
versionChannelsconsistently in the body schema:- deploymentVersionChannels: z.array(z.string()), + versionChannels: z.array(z.string()),Choose the approach that aligns with the broader codebase terminology.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.ts (1)
5-25: Ensure handling for non-browser environments
Currently, the code callswindow.location.hrefdirectly, which may break SSR. If you intend this hook only for client usage, consider a guard fortypeof window !== 'undefined'. Otherwise, the logic appears sound and consistent with Next.js patterns.packages/api/src/router/deployment-version.ts (3)
63-82: Update procedure is straightforward
Checks user authorization, updates deployment version channel, and returns updated rows. Code is clear. If you want to confirm existence before updating, consider throwing an error if no rows are affected.
84-96: Consider returning the deleted record
Thedeleteprocedure functions correctly. If you need verification, you could return the deleted item to confirm success or a “not found” scenario.
98-130: Potential optimization for channel listing
Computingchannels.map+ a separate query per channel is fine for moderate data sizes. For performance at scale, consider a single joined query or a window function to avoid N+1 patterns.packages/api/src/router/environment.ts (2)
60-66: Consider renaming properties for consistent terminology.The variables
releaseChannelPolicyId,releaseChannelDeploymentId, andreleaseChannelFiltermay cause confusion now that the code is referencingenvironmentPolicyDeploymentVersionChannel. Consider renaming these keys to something likeversionChannelPolicyId,versionChannelDeploymentId, andversionChannelFilterto improve maintainability.
106-114: Align object property names withversionChannels.The mapped object still references fields like
releaseChannelIdandreleaseChannelDeploymentIdunderversionChannels. Consider updating them for consistent naming (e.g.,versionChannelId,versionChannelDeploymentId).apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsx (1)
22-26: Consider adjusting thesetIsOpennaming for clarity.Here,
setIsOpenis bound to a function that removes the channel ID from the search parameters. While it works, it might be slightly confusing as it doesn’t truly toggle a boolean state. Renaming could make this more intuitive.apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx (3)
67-68: UI text inconsistency with code naming.While the code variables have been updated to use
deploymentVersionChannel, the UI text still refers to "release channel". Consider updating UI text to match the new terminology for consistency.- {deploymentVersionChannel?.name ?? `Select release channel...`} + {deploymentVersionChannel?.name ?? `Select deployment version channel...`}
73-74: UI text inconsistency with code naming.The placeholder text still refers to "release channels" while the code has been updated to use the new terminology.
- <CommandInput placeholder="Search release channels..." /> + <CommandInput placeholder="Search deployment version channels..." />
149-156: UI text inconsistency with code naming.The heading and column header still refer to "Release Channels" while the code has been updated to use "DeploymentVersionChannels".
- Release Channels{" "} + Deployment Version Channels{" "}- <span className="w-72">Release Channel</span> + <span className="w-72">Deployment Version Channel</span>apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsx (3)
67-68: UI text inconsistency with code naming.While the code variables have been updated to use
deploymentVersionChannel, the UI text still refers to "release channel". Consider updating UI text to match the new terminology for consistency.- {deploymentVersionChannel?.name ?? `Select release channel...`} + {deploymentVersionChannel?.name ?? `Select deployment version channel...`}
73-74: UI text inconsistency with code naming.The placeholder text still refers to "release channels" while the code has been updated to use the new terminology.
- <CommandInput placeholder="Search release channels..." /> + <CommandInput placeholder="Search deployment version channels..." />
149-156: UI text inconsistency with code naming.The heading and column header still refer to "Release Channels" while the code has been updated to use "DeploymentVersionChannels".
- Release Channels{" "} + Deployment Version Channels{" "}- <span className="w-72">Release Channel</span> + <span className="w-72">Deployment Version Channel</span>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (39)
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/checks/_components/flow-diagram/EnvironmentNode.tsx(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/DeploymentPageContent.tsx(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/release-cell/ReleaseEnvironmentCell.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/CreateDeploymentVersionChannelDialog.tsx(5 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/DeploymentVersionChannelsTable.tsx(1 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/page.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/page.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx(5 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsx(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx(5 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsx(7 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Usage.tsx(1 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.ts(1 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/resource-drawer/DeploymentResourceDrawer.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/policy-override/UpdateOverride.tsx(2 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/drawer/JobDrawer.tsx(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/drawer/EnvironmentPolicyDrawer.tsx(5 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsx(5 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/ReleaseConditionDialog.tsx(4 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/useReleaseFilter.ts(3 hunks)apps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.ts(2 hunks)apps/webservice/src/app/api/v1/environments/route.ts(3 hunks)apps/webservice/src/app/api/v1/release-channels/route.ts(3 hunks)packages/api/src/router/deployment-version.ts(8 hunks)packages/api/src/router/deployment.ts(2 hunks)packages/api/src/router/environment-policy.ts(9 hunks)packages/api/src/router/environment.ts(3 hunks)packages/db/src/create-env.ts(3 hunks)packages/db/src/schema/environment-policy-relations.ts(1 hunks)packages/db/src/schema/environment.ts(2 hunks)packages/db/src/schema/release-channel-relations.ts(1 hunks)packages/db/src/schema/release-channel.ts(2 hunks)packages/db/src/schema/release.ts(2 hunks)packages/job-dispatch/src/environment-creation.ts(4 hunks)packages/job-dispatch/src/environment-release-channel-update.ts(2 hunks)packages/job-dispatch/src/policies/release-sequencing.ts(1 hunks)packages/job-dispatch/src/policies/release-string-check.ts(1 hunks)packages/job-dispatch/src/resource/dispatch-resource.ts(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/db/src/schema/environment.ts
🚧 Files skipped from review as they are similar to previous changes (10)
- apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/CreateDeploymentVersionChannelDialog.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/drawer/JobDrawer.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/page.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/ReleaseConditionDialog.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/drawer/EnvironmentPolicyDrawer.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Overview.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDropdown.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/_components/release-cell/ReleaseEnvironmentCell.tsx
- apps/webservice/src/app/[workspaceSlug]/(app)/_components/environment/drawer/policy-override/UpdateOverride.tsx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...
**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.
packages/db/src/schema/environment-policy-relations.tsapps/webservice/src/app/api/v1/release-channels/route.tsapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Usage.tsxpackages/job-dispatch/src/policies/release-sequencing.tsapps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/resource-drawer/DeploymentResourceDrawer.tsxpackages/job-dispatch/src/policies/release-string-check.tsapps/webservice/src/app/api/v1/environments/route.tspackages/job-dispatch/src/environment-creation.tspackages/db/src/schema/release.tsapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/page.tsxapps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.tspackages/job-dispatch/src/environment-release-channel-update.tsapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/checks/_components/flow-diagram/EnvironmentNode.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/DeploymentPageContent.tsxpackages/db/src/schema/release-channel-relations.tspackages/api/src/router/deployment.tsapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsxpackages/api/src/router/environment.tsapps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.tspackages/api/src/router/deployment-version.tsapps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/useReleaseFilter.tspackages/db/src/create-env.tspackages/job-dispatch/src/resource/dispatch-resource.tspackages/api/src/router/environment-policy.tspackages/db/src/schema/release-channel.tsapps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsxapps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/DeploymentVersionChannelsTable.tsx
🧠 Learnings (1)
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Usage.tsx (1)
Learnt from: adityachoudhari26
PR: ctrlplanedev/ctrlplane#188
File: apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx:42-44
Timestamp: 2025-03-14T19:06:31.548Z
Learning: In `apps/webservice/src/app/[workspaceSlug]/_components/release-channel-drawer/Usage.tsx`, within the `Usage` component, the arrays used for filtering inherited environments are expected to remain small. Therefore, performance optimizations for this filtering logic are not necessary.
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Lint
- GitHub Check: Typecheck
- GitHub Check: build (linux/amd64)
- GitHub Check: build (linux/amd64)
- GitHub Check: build (linux/amd64)
🔇 Additional comments (104)
packages/db/src/schema/environment-policy-relations.ts (2)
4-4: Import path remains unchanged despite renamed importThe import name has been changed from
environmentPolicyReleaseChanneltoenvironmentPolicyDeploymentVersionChannel, but it's still being imported from the same file path "./release-channel.js". This is consistent with the broader refactoring effort to rename Release Channel to Deployment Version Channel throughout the codebase.
9-11: Relation property renamed consistentlyThe property name in the relations definition has been updated from
environmentPolicyReleaseChannelstoenvironmentPolicyDeploymentVersionChannels, and is now correctly referencing the newly importedenvironmentPolicyDeploymentVersionChannelschema. This change is consistent with the PR's objective of renaming Release Channel to Deployment Version Channel.apps/webservice/src/app/api/v1/release-channels/route.ts (1)
50-52: Variable rename completed consistentlyThe variable has been renamed from
releaseChanneltodeploymentVersionChannelconsistently in the return statement, which aligns with the PR's goal of standardizing terminology across the codebase.apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/Usage.tsx (1)
4-6: Type definition updated to match new API path structureThe type definition has been correctly updated to reflect the new API structure, changing from
RouterOutputs["deployment"]["releaseChannel"]["byId"]toRouterOutputs["deployment"]["version"]["channel"]["byId"]. This is consistent with the broader refactoring effort to standardize on "deployment version channel" terminology.Based on the retrieved learnings, I note that the arrays used for filtering in this component are expected to remain small, so no performance optimizations are needed in the filtering logic.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/resource-drawer/DeploymentResourceDrawer.tsx (1)
80-80: LGTM! Updated filter parameter to match schema changes.The update from
releaseFiltertoversionSelectormaintains consistency with the schema changes inpackages/db/src/schema/release.ts.apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/page.tsx (1)
50-50: LGTM! Updated prop name to match component interface.The property has been correctly renamed to
deploymentVersionChannelto maintain consistency with the refactoring.apps/webservice/src/app/api/v1/environments/route.ts (2)
18-18: LGTM! Updated schema property name for consistency.The refactoring from
releaseChannelstodeploymentVersionChannelsis consistent with the terminology changes throughout the codebase.Also applies to: 51-51
57-61: LGTM! Updated query condition with new DB field name.The database query has been properly updated to use the renamed field and parameter.
packages/db/src/schema/release.ts (3)
64-66: LGTM! Updated field name in database schema.The field name has been correctly updated from
releaseFiltertoversionSelectorwhile maintaining the same type and default value.
76-76: LGTM! Updated schema validation to match field name.The validation schema has been correctly updated to use
versionSelectorinstead ofreleaseFilter, maintaining consistency with the database schema.
91-93:❓ Verification inconclusive
Inconsistent naming pattern for similar fields.
The
releaseDependencytable still usesreleaseFilterwhile thedeploymentVersionChanneltable now usesversionSelector. Both appear to serve similar purposes but have different naming patterns.Consider whether the
releaseFilterfield inreleaseDependencyshould also be renamed for consistency:- releaseFilter: jsonb("deployment_version_selector") + versionSelector: jsonb("deployment_version_selector")Please verify whether this is intentional or if
releaseDependencyshould also be updated:
🏁 Script executed:
#!/bin/bash # Check for other occurrences of releaseFilter and how they're used rg "releaseFilter" --type tsLength of output: 3614
Naming Inconsistency: Verify if Renaming is Intended
The code for the
releaseDependencytable still uses the fieldreleaseFilter, while the corresponding functionality in thedeploymentVersionChanneltable has been updated to useversionSelector. Our grep search confirms thatreleaseFilteris widely used across the codebase (in databases, policies, API definitions, and UI components), indicating that renaming this field may have far-reaching implications.
- Action: Please verify whether the difference in naming is intentional.
- If the goal is to standardize the naming for clarity and consistency, the rename should be applied not only in the schema (e.g., in
packages/db/src/schema/release.ts) but also updated in all consumer modules (as seen in job-dispatch policies, OpenAPI definitions, the SDK, and frontend components).- Otherwise, if the distinction is deliberate, please add documentation/comment clarifying the rationale for maintaining different names.
Proposed Change (if renaming is the desired direction):
- releaseFilter: jsonb("deployment_version_selector") + versionSelector: jsonb("deployment_version_selector")packages/job-dispatch/src/environment-release-channel-update.ts (2)
20-28: Function rename reflects improved semantics.The function
getVersionSelectornow better reflects its purpose of retrieving a version selector rather than a release filter. The property access also correctly usesr?.versionSelectorinstead ofr?.releaseFilter, maintaining consistency with the new naming conventions.
146-148: Function calls properly updated.The function calls have been properly updated to use the new
getVersionSelectorfunction name, maintaining consistency with the refactored function declared on line 20.apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/checks/_components/flow-diagram/EnvironmentNode.tsx (4)
27-28: Import statements correctly updated.The import statements have been properly updated to use the new hook names
useDeploymentVersionChannelDraweranduseDeploymentVersionChannel, aligning with the broader refactoring effort.
135-146: Component successfully renamed with proper hook usage.The component has been renamed from
ReleaseChannelChecktoDeploymentVersionChannelCheck, and it now correctly uses the updated hooks with proper destructuring of their returned values.
150-192: Component implementation updated with consistent terminology.All references to the old terminology have been replaced throughout the component implementation. The UI rendering logic and user interaction handlers now correctly use the new variable and function names like
deploymentVersionChannelIdandsetDeploymentVersionChannelId.
279-280: Component reference updated in parent component.The parent component
EnvironmentNodenow correctly references the renamed componentDeploymentVersionChannelCheck.packages/db/src/schema/release-channel.ts (2)
8-26: Database schema constant renamed consistently.The exported constant has been renamed from
environmentPolicyReleaseChanneltoenvironmentPolicyDeploymentVersionChannel, while maintaining the same table structure and constraints.
28-30: Type definition updated to match renamed constant.The type definition has been updated to
EnvironmentPolicyDeploymentVersionChanneland correctly references the renamed constant, ensuring type safety throughout the application.packages/job-dispatch/src/policies/release-string-check.ts (2)
21-37: Database query updated with new schema references.The database query has been correctly updated to use the new schema references:
- Changed field selections to use
schema.environmentPolicyDeploymentVersionChannel- Updated to access
schema.deploymentVersionChannel.versionSelectorinstead ofreleaseFilter- Updated the
fromclause and join condition to use the renamed schema constantThese changes maintain the query's functionality while aligning with the refactored schema names.
81-86: Variable reference maintained in downstream code.The code correctly continues to use the
releaseChannelDeploymentIdandreleaseChannelFiltervariable names in this section. This is acceptable since these are local variable names within the function that don't affect the external API or database schema references.apps/webservice/src/app/[workspaceSlug]/(app)/_hooks/channel/useDeploymentVersionChannel.ts (5)
13-13: Function renamed appropriately to match new terminology.The hook function name has been changed from
useReleaseChanneltouseDeploymentVersionChannelto maintain naming consistency with the broader refactoring effort.
20-27: Variable and property names updated consistently.All references to
releaseChannelterminology have been properly updated:
policyReleaseChannel→policyDeploymentVersionChannel.policy.releaseChannels→.policy.versionChannelsreleaseChannel→versionSelectorThe changes maintain the same functionality while using the new naming convention.
46-48: Boolean variables renamed to reflect new terminology.The boolean variables have been correctly renamed:
hasReleaseChannel→hasDeploymentVersionChannelisReleaseChannelMatchingFilter→isDeploymentVersionChannelMatchingFilterThese changes maintain code readability while aligning with the new naming standards.
53-54: Derived boolean variable name updated.Variable
isPassingReleaseChannelhas been properly renamed toisPassingDeploymentVersionChannelwhile preserving the same logical condition.
56-60: Return object properties renamed correctly.The hook's return object properties have been updated to match the new terminology:
isPassingReleaseChannel→isPassingDeploymentVersionChannelreleaseChannelId→deploymentVersionChannelIdThese changes maintain the same API contract with updated naming.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/DeploymentPageContent.tsx (4)
178-178: Type property renamed correctly in props interface.The
DeploymentPageContentPropstype has been updated to usedeploymentVersionChannelinstead ofreleaseChannel, maintaining consistent terminology.
186-186: Component parameter renamed consistently.The destructured parameter has been renamed from
releaseChanneltodeploymentVersionChannel, matching the prop type definition.
214-214: Property name updated in ReleaseConditionDialog component.The property passed to
ReleaseConditionDialoghas been updated fromreleaseChannelstodeploymentVersionChannels, maintaining consistency with the terminology changes.
225-225: Condition check updated to use new variable name.The condition check has been correctly updated to reference
deploymentVersionChannelinstead ofreleaseChannel.packages/job-dispatch/src/environment-creation.ts (5)
25-28: Database query property path updated consistently.The query property path has been updated from
environmentPolicyReleaseChannelstoenvironmentPolicyDeploymentVersionChannelswith the nested property also updated fromreleaseChanneltodeploymentVersionChannel.
37-37: Destructured variable name updated correctly.The destructured variable from the policy object has been renamed from
environmentPolicyReleaseChannelstoenvironmentPolicyDeploymentVersionChannels.
52-53: Variable reference updated to match new naming convention.The reference to
environmentPolicyReleaseChannelshas been updated toenvironmentPolicyDeploymentVersionChannelsin the find operation.
55-55: Property name updated in destructuring assignment.The destructured property name has been updated from
releaseFiltertoversionSelectorto match the new field name in the database schema.
64-64: Database query parameter updated to use new variable name.The parameter passed to
SCHEMA.deploymentVersionMatchesConditionhas been updated to useversionSelectorinstead of the previous filter name.packages/db/src/create-env.ts (4)
9-13: Function renamed and parameter updated.The function has been renamed from
createReleaseChannelstocreateVersionChannelswith the parameter updated fromreleaseChannelstodeploymentVersionChannels, maintaining consistent terminology across the codebase.
14-15: Database operation updated to use new schema entity.The database insert operation has been updated to use
SCHEMA.environmentPolicyDeploymentVersionChannelinstead of the previous entity name, maintaining consistency with the database schema changes.
26-26: Destructured input property name updated.The destructured property has been renamed from
releaseChannelstoversionChannelsto match the updated input structure.
50-51: Condition check and function call updated to use new names.The condition check and function call have been updated to use
versionChannelsandcreateVersionChannelsrespectively, maintaining consistent naming throughout the function.apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/useDeploymentVersionChannelDrawer.ts (2)
1-2: No issues with import usage
These imports from"next/navigation"are appropriate and align with Next.js 13+ patterns.
3-3: Constant name is clear and consistent
The constantparamimproves maintainability by centralizing the URL query key.packages/db/src/schema/release-channel-relations.ts (3)
4-4: Renamed import is consistent
ImportingenvironmentPolicyDeploymentVersionChannelaligns with the transition from release to deployment version channels.
10-12: Naming is consistent with the new schema
TheenvironmentPolicyDeploymentVersionChannelsrelation name matches the updated model references. No functional issues found.
16-28: Proper referencing of fields in environmentPolicyDeploymentVersionChannelRelations
All foreign key references match the updated schema for deployment version channels, ensuring data integrity.packages/api/src/router/deployment-version.ts (8)
49-61: Creation logic looks correct
Thecreatemutation properly validates user permissions and inserts a new deployment version channel. Transaction usage is optional here, but consider it if you introduce future multi-step creates.
132-172: Detailed retrieval of environment policies
ThebyIdquery thoroughly fetches environment policies. Code usage oftakeFirstis correct, and the approach is consistent with Drizzle ORM patterns.
176-176: Router composition is valid
Exposingchannel: versionChannelRouterensures modular access to channel operations. No concerns here.
384-391: Subquery usage for environment-policy alignment
policyRCSubqueryis logically consistent with environment-policy relationships. Good approach for referencing specific channels within environment policies.
420-420: Correct reference update
eq(policyRCSubquery.deploymentVersionChannelPolicyId, SCHEMA.environmentPolicy.id)handles the renamed keys properly.
446-449: Value lookup by deployment ID
find(...)checkingrc.deploymentVersionChannelDeploymentId === rel.deploymentIdeffectively maps the correct channel. Consider how multiple matching channels are handled if they exist.
450-455: Maintaining consistency in blocked logic
This destructuring smoothly passesdeploymentVersionChannelVersionSelectortodeploymentVersionMatchesCondition. The null check approach is clear and prevents accidental param usage when the channel is missing.
709-755: Flexible left joins for environment-based filtering
These lines integrate the deploymentVersionChannel references into the environment-based query. Logic properly checks the environment’s associated policy to match versions. No issues.packages/api/src/router/deployment.ts (2)
430-432: Consistent rename toversionChannels.This mapping and filtering logic looks good, aligning with the transition from release channels to version channels.
468-472: Use of Lodash chain is appropriate.Chaining with map, filter, and uniqBy effectively manages duplicates. Good work maintaining clarity.
packages/api/src/router/environment.ts (3)
23-23: New import reference forenvironmentPolicyDeploymentVersionChannel.No issues found; the import aligns with the renamed schema object.
69-70: Renamed source table usage looks correct.Referencing the new
environmentPolicyDeploymentVersionChanneltable is consistent with the renaming.
73-73: Properly referencingchannelId.This is consistent with the renamed schema fields.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/channel/drawer/DeploymentVersionChannelDrawer.tsx (7)
17-17: Dropdown import matches new component name.The renamed import matches the broader refactor to deployment version channels.
20-20: Updated hook import name is consistent.Renaming the hook from “releaseChannel” to “deploymentVersionChannel” maintains clarity.
28-33: Query and data extraction logic look straightforward.Using
deploymentVersionChannelId ?? ""and theenabled: isOpencondition is clean and readable.
35-35: Loading variable assignment is concise.No issues here; extracting
isLoadingimproves code readability.
50-60: Drawer title and dropdown integration look good.Using the data from
deploymentVersionChanneland rendering the dropdown is clear.
81-84: PassingdeploymentVersionChannelto Overview is correct.No concerns found. The prop name is consistent with the usage.
86-87: Usage component integration is properly updated.Supplying
deploymentVersionChannel.usagealigns with the refactored approach.packages/api/src/router/environment-policy.ts (9)
21-21: Good naming conversion from environmentPolicyReleaseChannel to environmentPolicyDeploymentVersionChannel.This import change is consistent with the PR objective of renaming "ReleaseChannel" to "DeploymentVersionChannel" throughout the codebase.
36-40: Correctly updated the join query to use the new table name.The left join operation has been properly updated to reference the new table name while maintaining the same join logic.
165-169: Rename from releaseChannels to versionChannels is consistent.This variable renaming maintains code functionality while adopting the new terminology.
184-186: Properly updated return property from releaseChannels to versionChannels.The renamed property in the return object ensures consistent naming across the interface.
259-259: Consistent destructuring of versionChannels from input data.Properly updated the variable name in destructuring to match the new naming convention.
269-279: Correctly updated database query to use the new table name.The query now properly references the new table name for fetching previous version channels.
296-302: Correctly updated delete operation to reference the new table.The delete operation has been updated to use the environmentPolicyDeploymentVersionChannel table.
306-317: Properly updated insert operation to use the new table.The insert and conflict handling logic has been updated to use the environmentPolicyDeploymentVersionChannel table.
320-329: Correctly updated query to fetch new version channels.The query now properly references the new table name and fields for retrieving the updated version channels.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/release/condition/useReleaseFilter.ts (5)
7-7: Renamed constant while preserving the URL parameter string.Good job maintaining the URL parameter string as "release_channel_id_filter" for backward compatibility while updating the variable name to deploymentVersionChannelParam.
13-15: Correctly updated variable name to match new terminology.The variable has been renamed from releaseChannelId to deploymentVersionChannelId while preserving functionality.
27-30: Updated function parameter name to match new terminology.The setFilter function parameter has been updated consistently with the renaming pattern.
37-43: Correctly updated URL parameter handling for the renamed parameter.The conditional checks and URL parameter manipulation logic has been updated to use the new parameter name.
58-58: Updated return object property to match new terminology.The hook's return object now correctly uses deploymentVersionChannelId instead of releaseChannelId.
packages/job-dispatch/src/resource/dispatch-resource.ts (6)
39-41: Correctly updated database query to use the new table name.The query has been updated to use environmentPolicyDeploymentVersionChannels with the appropriate nested property references.
70-71: Variable name updated to match new terminology.The destructured property is now using the renamed variable environmentPolicyDeploymentVersionChannels.
72-74: Properly updated variable reference in the find condition.The find operation uses the renamed variable while maintaining the same logic.
76-77: Correctly updated property access to use versionSelector instead of releaseFilter.The property access and object spread have been updated to use the new property name versionSelector, maintaining the same functionality.
84-85: Updated parameter name in map function to match new terminology.The destructured parameter name has been updated from releaseFilter to versionSelector in the map callback.
93-94: Correctly passed versionSelector to the condition matching function.The parameter passed to SCHEMA.deploymentVersionMatchesCondition has been updated to use versionSelector.
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(sidebar)/channels/DeploymentVersionChannelsTable.tsx (4)
1-17: Well-structured component imports and client directive.The imports are organized clearly and include necessary UI components and hooks. The client directive is correctly placed at the top of the file.
18-20: Good type definition extending the schema type.The DeploymentVersionChannel type properly extends the schema type and adds the total property for tracking the number of releases.
22-28: Clear and concise props type definition.The props type is well-defined and follows TypeScript best practices with proper naming convention.
29-64: Well-implemented table component for displaying deployment version channels.The component is well-structured with proper use of the Table components. It correctly:
- Uses the hook to manage the selected channel
- Maps over the channels to render each row
- Implements a click handler to select channels
- Conditionally renders the ReleaseConditionBadge when a versionSelector is present
apps/webservice/src/app/[workspaceSlug]/(app)/(deploy)/(raw)/systems/[systemSlug]/(raw)/environments/[environmentId]/policies/channels/DeploymentVersionChannels.tsx (7)
22-29: Props and function names properly refactored.The
DeploymentSelectPropstype has been correctly updated to use the newdeploymentVersionChannelsandupdateDeploymentVersionChannelnaming convention, maintaining consistency with the refactoring initiative.
31-44: Component props updated appropriately.The
DeploymentSelectcomponent has been properly updated to use the new naming convention for its props and function calls. The implementation logic remains intact while maintaining consistency with the refactoring.
50-52: Variable naming updated correctly.The sorting logic has been updated from
sortedReleaseChannelstosortedDeploymentVersionChannels, maintaining consistency with the refactoring initiative.
113-120: Type and component renamed appropriately.The
ReleaseChannelPropstype has been correctly renamed toDeploymentVersionChannelPropsand theReleaseChannelscomponent has been renamed toDeploymentVersionChannels. These changes are consistent with the refactoring initiative.
123-125: Variable name updated correctly.The filtering logic has been updated to use
deploymentsWithDeploymentVersionChannelsand check forversionChannelsinstead ofreleaseChannels, maintaining consistency with the refactoring initiative.
127-133: Object construction logic updated correctly.The logic for creating the
currDeploymentVersionChannelsobject has been properly updated to use the new naming convention.
135-144: Function renamed and updated appropriately.The
updateReleaseChannelfunction has been correctly renamed toupdateDeploymentVersionChanneland updated to work with the new object names.apps/webservice/src/app/[workspaceSlug]/(app)/_components/policy/form/DeploymentVersionChannels.tsx (9)
16-18: Type definition properly updated.The
Deploymenttype has been correctly updated to useversionChannelsinstead ofreleaseChannels, maintaining consistency with the refactoring initiative.
20-20: Type definition properly updated.The
Policytype has been correctly updated to useversionChannelsinstead ofreleaseChannels.
22-29: Props and function names properly refactored.The
DeploymentSelectPropstype has been correctly updated to use the newdeploymentVersionChannelsandupdateDeploymentVersionChannelnaming convention.
31-44: Component props updated appropriately.The
DeploymentSelectcomponent has been properly updated to use the new naming convention for its props and function calls. The implementation logic remains intact while maintaining consistency with the refactoring.
50-52: Variable naming updated correctly.The sorting logic has been updated from
sortedReleaseChannelstosortedDeploymentVersionChannels, maintaining consistency with the refactoring initiative.
113-122: Type and component renamed appropriately.The
ReleaseChannelPropstype has been correctly renamed toDeploymentVersionChannelPropsand theReleaseChannelscomponent has been renamed toDeploymentVersionChannels. These changes align with the component export and maintain consistency with the refactoring initiative.
123-125: Variable name updated correctly.The filtering logic has been updated to use
deploymentsWithDeploymentVersionChannelsand check forversionChannelsinstead ofreleaseChannels, maintaining consistency with the refactoring initiative.
127-133: Object construction logic updated correctly.The logic for creating the
currDeploymentVersionChannelsobject has been properly updated to use the new naming convention.
135-144: Function renamed and updated appropriately.The
updateReleaseChannelfunction has been correctly renamed toupdateDeploymentVersionChanneland updated to work with the new object names.
Summary by CodeRabbit