fix: Remove reference to regex condition

[adityachoudhari26]

Summary by CodeRabbit

• Refactor

  • Streamlined condition selectors by removing regex-based matching options and updating input placeholders for a more intuitive filter experience.

• Chores

  • Consolidated matching logic across conditions to ensure uniform behavior when filtering and displaying deployment, job, and resource data.

[coderabbitai]

Walkthrough

The pull request removes regex-based functionality from various parts of the application. In UI components, the regex option is removed from condition selectors and operator mappings. In the database schema, regex-related checks have been removed and replaced with simplified substring matching logic using the ilike operator. Similarly, regex entries are eliminated from validation and enum definitions in the validators package. No public API changes were introduced, and the modifications streamline the condition handling across deployments, filters, job conditions, resources, and associated database queries.

Changes

File(s)	Change Summary
apps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/version/condition/DeploymentVersionConditionBadge.tsx apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/condition/JobConditionBadge.tsx apps/webservice/src/app/[workspaceSlug]/(app)/_components/resources/condition/ResourceConditionBadge.tsx	Removed regex operator entries from the operatorVerbs object, eliminating the "matches" mapping for regex-based conditions.
apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/ColumnConditionRender.tsx apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/MetadataConditionRender.tsx	Removed the regex/MetadataOperator.Regex option from operator selectors and replaced conditional regex placeholders with a static "Value".
packages/db/src/schema/deployment-version.ts packages/db/src/schema/job.ts packages/db/src/schema/resource.ts	Removed regex-based conditional checks and simplified substring matching logic, now consistently using the ilike operator.
packages/validators/src/conditions/index.ts packages/validators/src/conditions/metadata-condition.ts packages/validators/src/releases/conditions/release-condition.ts packages/validators/src/resources/conditions/resource-condition.ts	Removed the Regex entry from enums and eliminated related regex validation objects and types from the validation logic.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant UI as UI Component
    participant VB as Validator/Builder
    participant DB as Database

    U->>UI: Selects condition operator
    UI->>VB: Sends operator (Regex option removed)
    VB->>DB: Builds simplified query using `ilike`
    DB-->>VB: Returns query result
    VB-->>UI: Displays condition outcome

Loading

Possibly related PRs

• fix: Reuse filter endpoints for deployment resource drawer #239: Modifies filtering logic and operator usage for job conditions, similar to these regex removal changes.
• fix: Remove like condition for column condition #231: Adjusts operator handling in condition components by removing regex support.
• fix: Remove semver and regex release filter #160: Eliminates regex-based capabilities from release filter logic, complementing the current changes.

Suggested reviewers

• jsbroks

Poem

I'm a rabbit hopping through the code, 🐰
Leaving regex trails behind on this road.
With clean logic now in every stride,
Simplicity and clarity side by side.
Hop along, let's celebrate this refined ride!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab39a1e and 62898c5.

📒 Files selected for processing (12)

• apps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/version/condition/DeploymentVersionConditionBadge.tsx (0 hunks)
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/ColumnConditionRender.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/MetadataConditionRender.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/condition/JobConditionBadge.tsx (0 hunks)
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/resources/condition/ResourceConditionBadge.tsx (0 hunks)
• packages/db/src/schema/deployment-version.ts (1 hunks)
• packages/db/src/schema/job.ts (1 hunks)
• packages/db/src/schema/resource.ts (2 hunks)
• packages/validators/src/conditions/index.ts (0 hunks)
• packages/validators/src/conditions/metadata-condition.ts (0 hunks)
• packages/validators/src/releases/conditions/release-condition.ts (0 hunks)
• packages/validators/src/resources/conditions/resource-condition.ts (0 hunks)

💤 Files with no reviewable changes (7)

• apps/webservice/src/app/[workspaceSlug]/(app)/_components/job/condition/JobConditionBadge.tsx
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/deployments/version/condition/DeploymentVersionConditionBadge.tsx
• packages/validators/src/releases/conditions/release-condition.ts
• packages/validators/src/conditions/index.ts
• packages/validators/src/resources/conditions/resource-condition.ts
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/resources/condition/ResourceConditionBadge.tsx
• packages/validators/src/conditions/metadata-condition.ts

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/MetadataConditionRender.tsx
• packages/db/src/schema/resource.ts
• packages/db/src/schema/deployment-version.ts
• apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/ColumnConditionRender.tsx
• packages/db/src/schema/job.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Typecheck
• GitHub Check: Lint
• GitHub Check: build (linux/amd64)

🔇 Additional comments (7)

apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/ColumnConditionRender.tsx (1)

53-53: Removal of regex placeholder completes the regex functionality removal.

The placeholder has been simplified from a conditional expression that likely displayed a regex pattern to a static "Value" string. This change is consistent with the removal of the regex option from the select items above (which was deleted in this PR).

apps/webservice/src/app/[workspaceSlug]/(app)/_components/filter/MetadataConditionRender.tsx (2)

95-102: Type definition correctly updated to remove Regex operator.

The type definition for onValueChange now properly excludes the MetadataOperator.Regex option, consistent with its removal from the available operators in the UI.

---

129-129: Input placeholder simplified with regex option removal.

The placeholder has been changed from what was likely a conditional expression showing a regex pattern to a static "Value" text, which aligns with the removal of regex functionality.

packages/db/src/schema/deployment-version.ts (1)

260-260: Simplified condition handling with consistent substring matching.

The function has been refactored to use a single return statement with the ilike operator for substring matching, removing special handling for the Contains operator. This change maintains the same functionality while simplifying the code, as substring matching with wildcards on both sides (%${cond.value}%) provides the same behavior as the previous Contains implementation.

packages/db/src/schema/resource.ts (2)

257-257: Simplified identifier condition handling with consistent substring matching.

The function has been refactored to use a single return statement with the ilike operator for substring matching, removing special handling for the Contains operator while maintaining the same functionality.

---

267-267: Simplified name condition handling with consistent substring matching.

Similarly to the identifier condition changes, this function now uses a single return statement with the ilike operator for substring matching, maintaining the same functionality while reducing code complexity.

packages/db/src/schema/job.ts (1)

251-251: Simplification of version condition to use substring matching

The code has been simplified to use a standard SQL ilike operator with the pattern %${cond.value}% for substring matching, replacing the previous regex-based approach. This change aligns with the PR objective of removing regex references throughout the codebase.

This approach:

1. Is more consistent with how other string operations are handled in the codebase
2. Typically offers better performance than regex matching in database queries
3. Makes the code more maintainable by using standard SQL patterns

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.