Skip to content

init dst tetsing #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 28, 2025
Merged

init dst tetsing #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dcc7f5b
init dst testing
adityachoudhari26 Mar 28, 2025
222c410
update
adityachoudhari26 Mar 28, 2025
ea45706
cleanup
jsbroks Mar 28, 2025
c2b66f1
fix formatting
jsbroks Mar 28, 2025
0e21ec4
undo changes
jsbroks Mar 28, 2025
73d2f33
remove utc
jsbroks Mar 28, 2025
3c0186b
nowdt
jsbroks Mar 28, 2025
d9c4996
cleanup
jsbroks Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
193 changes: 103 additions & 90 deletions packages/rule-engine/src/rules/__tests__/deployment-deny-rule.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ describe("DeploymentDenyRule", () => {
const rule = new DeploymentDenyRule({
freq: Frequency.WEEKLY,
byweekday: [RRule.MO, RRule.TU, RRule.WE, RRule.TH, RRule.FR], // Weekdays
dtstart: new Date("2023-01-02T14:00:00Z"), // 9:00 AM EST (UTC-5)
dtend: new Date("2023-01-02T22:00:00Z"), // 5:00 PM EST (UTC-5)
dtstart: new Date("2023-01-02T09:00:00Z"), // 9:00 AM EST (UTC-5)
dtend: new Date("2023-01-02T17:00:00Z"), // 5:00 PM EST (UTC-5)
tzid: "America/New_York",
});

Expand All @@ -182,92 +182,105 @@ describe("DeploymentDenyRule", () => {
expect(result.reason).toBeUndefined();
});

// it("should handle DST changes correctly", () => {
// // Create a rule that denies deployments at 2:30 AM ET every day
// // This test will check behavior around the DST change boundary
// const rule = new DeploymentDenyRule({
// freq: Frequency.DAILY,
// dtstart: new Date("2023-03-11T07:30:00Z"), // 2:30 AM ET before DST change
// dtend: new Date("2023-03-11T07:45:00Z"), // 2:45 AM ET before DST change
// tzid: "America/New_York",
// });

// // Mock date just before DST change - 2:30 AM EST (March 12, 2023)
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new TZDate("2023-03-12T07:30:00Z", "UTC"), // 2:30 AM EST
// );
// let result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(0);
// expect(result.reason).toBeDefined();

// // Mock date just after DST change - 2:30 AM EDT
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new TZDate("2023-03-13T07:30:00Z", "UTC"), // 2:30 AM EDT (UTC-4 after the change)
// );
// result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(0);
// expect(result.reason).toBeDefined();

// // Mock a time outside the deny window - 3:30 AM EDT
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new TZDate("2023-03-13T07:30:00Z", "UTC"), // 3:30 AM EDT
// );
// result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(2);
// expect(result.reason).toBeUndefined();
// });

// it("should handle DST change in the fall correctly", () => {
// // Create a rule that denies deployments at 1:30 AM ET every day
// // This will test the "repeated hour" during fall DST change
// const rule = new DeploymentDenyRule({
// freq: Frequency.DAILY,
// dtstart: new Date("2023-11-04T05:30:00Z"), // 1:30 AM EDT before DST change
// dtend: new Date("2023-11-04T05:45:00Z"), // 1:45 AM EDT before DST change
// tzid: "America/New_York",
// });

// // 1:30 AM EDT before the change
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new Date("2023-11-05T05:30:00Z"), // 1:30 AM EDT (UTC-4)
// );
// let result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(0);
// expect(result.reason).toBeDefined();

// // 1:30 AM EST after the change (the "repeated hour")
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new Date("2023-11-05T06:30:00Z"), // 1:30 AM EST (UTC-5 after the change)
// );
// result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(0);
// expect(result.reason).toBeDefined();
// });

// it("should handle complex recurrence rules with DST correctly", () => {
// // Create a rule for a maintenance window that happens every Sunday at 2:00 AM local time
// const rule = new DeploymentDenyRule({
// freq: Frequency.WEEKLY,
// byweekday: [RRule.SU], // Sunday
// dtstart: new Date("2023-03-05T07:00:00Z"), // 2:00 AM ET, Sunday before DST change
// dtend: new Date("2023-03-05T11:00:00Z"), // 6:00 AM ET, Sunday before DST change
// timezone: "America/New_York",
// });

// // Check Sunday March 12, 2023 at 2:30 AM (during DST change)
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new Date("2023-03-12T07:30:00Z"), // 2:30 AM EST during DST change
// );
// let result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(0);
// expect(result.reason).toBeDefined();

// // Check Sunday April 2, 2023 at 2:30 AM (after DST change)
// vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
// new Date("2023-04-02T06:30:00Z"), // 2:30 AM EDT after DST change (UTC-4)
// );
// result = rule.filter(context, releases);
// expect(result.allowedReleases.length).toBe(0);
// expect(result.reason).toBeDefined();
// });
it("should handle standard time to daylight time changes correctly (EST -> EDT in March)", () => {
const rule = new DeploymentDenyRule({
freq: Frequency.DAILY,
dtstart: new Date("2023-03-09T09:00:00Z"), // 9:00am EST
dtend: new Date("2023-03-09T17:00:00Z"), // 5:00pm EST
tzid: "America/New_York",
});

/**
* These test UTC 21:30
* during EST, this is 4:30pm, which is during the denied period
* during EDT, this is 5:30pm, which is outside the denied period
* hence, before the DST change, the rule should deny access,
* and should allow access after the DST change
*/
vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-03-11T21:30:00Z"),
);
let result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(0);
expect(result.reason).toBeDefined();

vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-03-12T21:30:00Z"),
);
result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(2);
expect(result.reason).toBeUndefined();

/**
* These test UTC 13:30
* during EST, this is 8:30am, which is during the denied period
* during EDT, this is 9:30am, which is outside the denied period
* hence, before the DST change, the rule should deny access,
* and should allow access after the DST change
*/
vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-03-11T13:30:00Z"),
);
result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(2);
expect(result.reason).toBeUndefined();

vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-03-12T13:30:00Z"),
);
const result2 = rule.filter(context, releases);
expect(result2.allowedReleases.length).toBe(0);
expect(result2.reason).toBeDefined();
});

it("should handle daylight time to standard time changes correctly (EDT -> EST in November)", () => {
const rule = new DeploymentDenyRule({
freq: Frequency.DAILY,
dtstart: new Date("2023-11-04T09:00:00Z"), // 9:00am EDT
dtend: new Date("2023-11-04T17:00:00Z"), // 5:00pm EDT
tzid: "America/New_York",
});

/**
* These test UTC 13:30
* during EDT, this is 9:30am, which is during the denied period
* during EST, this is 8:30am, which is outside the denied period
* hence, before the DST change, the rule should deny access,
* and should allow access after the DST change
*/
vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-11-04T13:30:00Z"),
);
let result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(0); // Should be DENIED
expect(result.reason).toBeDefined();

vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-11-05T13:30:00Z"),
);
result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(2); // Should be ALLOWED
expect(result.reason).toBeUndefined();

/**
* These test UTC 21:30
* during EDT, this is 5:30pm, which is outside the denied period
* during EST, this is 4:30pm, which is during the denied period
* hence, before the DST change, the rule should allow access,
* and should deny access after the DST change
*/
vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-11-04T21:30:00Z"),
);
result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(2); // Should be ALLOWED
expect(result.reason).toBeUndefined();

vi.spyOn(rule as any, "getCurrentTime").mockReturnValue(
new Date("2023-11-05T21:30:00Z"),
);
result = rule.filter(context, releases);
expect(result.allowedReleases.length).toBe(0); // Should be DENIED
expect(result.reason).toBeDefined();
});
});
Loading
Loading