Skip to content

Conversation

@zacharyblasczyk
Copy link
Member

@zacharyblasczyk zacharyblasczyk commented Mar 29, 2025

Push model (GitHub): Pending → InProgress → Terminal states
Pull model (Windows/Linux exec): Pending → InProgress → Executing → Terminal states

Summary by CodeRabbit

  • New Features

    • Introduced a new "Executing" job status across the application.
    • Enhanced job status reporting with dedicated color indicators, icons, and human-readable labels for clearer progress visualization.
  • Chores

    • Improved the build configuration to exclude additional directories, streamlining the development process.

@zacharyblasczyk zacharyblasczyk marked this pull request as ready for review March 29, 2025 22:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 29, 2025

Walkthrough

This pull request introduces a new job status, "executing," across various parts of the system. The changes update color mappings, labels, and icons in the UI components, extend the OpenAPI and Node SDK enums, modify the database schema and migration journal, and adjust validator logic. Additionally, there is a minor update to the TypeScript configuration to exclude the "dist" directory from compilation. All modifications are additive and aim to broaden the job status representation.

Changes

File(s) Change Summary
apps/webservice/.../(deploy)/_utils/status-color.ts
apps/webservice/.../insights/DailyJobsChart.tsx
apps/webservice/.../resources/(raw)/[resourceId]/visualize/nodes/DeploymentNode.tsx
Added the "executing" status with associated color values (blue shades), a new label ("Executing") in the chart, and an icon (IconPlayerPlay), with updated conditions to include "executing" as in progress.
apps/webservice/.../api/v1/openapi.ts
openapi.v1.json
Extended the JobStatus schema by adding the "executing" value to the enumerated job statuses in the API specification.
packages/db/drizzle/0083_legal_falcon.sql
packages/db/drizzle/meta/_journal.json
packages/db/src/schema/job.ts
Updated the database by altering the job_status enum to include "executing", with a corresponding journal entry for migration tracking.
packages/node-sdk/src/schema.ts Added "executing" to the JobStatus enum within the components’ interface to support enhanced status tracking in the SDK.
packages/rule-engine/tsconfig.json Modified the TypeScript configuration to exclude both "node_modules" and the "dist" directory during compilation.
packages/validators/src/jobs/conditions/status-condition.ts
packages/validators/src/jobs/index.ts
Introduced "executing" into the job status enumerations and updated the human-readable mapping for job statuses.

Sequence Diagram(s)

sequenceDiagram
    participant JobHandler
    participant DB
    participant API
    participant UI
    JobHandler->>DB: Update job status to "executing"
    DB-->>API: Acknowledge status update ("executing")
    API-->>UI: Return job status with extended enum (including "executing")
    UI->>UI: Map "executing" to blue color and render play icon
    UI->>User: Display job as "executing"
Loading

Possibly related PRs

  • fix: Create jobs for latest valid releases on env create #197: The changes in the main PR, which add a new entry for the executing status in the statusColor object, are related to the retrieved PR that introduces a new job status JobStatus.Executing in the statusColors object, as both modifications involve the same job status concept and its representation.
  • fix: Show different statuses on graph #156: The changes in the main PR, which add a new entry for the executing status in the statusColor object, are related to the retrieved PR that introduces a new statusColors object mapping job statuses, including executing, to specific colors for visual representation.
  • fix: Show analytics on deployment page #299: The changes in the main PR, which add a new entry for the executing status in the statusColor object, are related to the retrieved PR that also introduces a new job status, JobStatus.Executing, affecting the representation of job statuses in the application.

Suggested reviewers

  • jsbroks

Poem

I’m a rabbit, hopping in the code lane,
Bringing “executing” to lighten up the domain.
Blue hues and icons now join the parade,
A touch of magic in every update made.
With each leap, our statuses sing—hip, hop, hooray!
🐰✨ Happy coding and a joyous day!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad356a9 and 660092f.

📒 Files selected for processing (1)
  • packages/db/drizzle/meta/_journal.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/db/drizzle/meta/_journal.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Typecheck
  • GitHub Check: Lint
  • GitHub Check: build (linux/amd64)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants