-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Add otel to event worker #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a3b8c7e
fix: Add otel to event worker
adityachoudhari26 edc2d98
update deps
adityachoudhari26 a971b78
Merge branch 'main' into add-instrumentation-event-worker
adityachoudhari26 e6b644b
Merge branch 'main' of github.com:sizzldev/ctrlplane into add-instrum…
adityachoudhari26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { getNodeAutoInstrumentations } from "@opentelemetry/auto-instrumentations-node"; | ||
| import { OTLPLogExporter } from "@opentelemetry/exporter-logs-otlp-http"; | ||
| import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-http"; | ||
| import { Resource } from "@opentelemetry/resources"; | ||
| import { BatchLogRecordProcessor } from "@opentelemetry/sdk-logs"; | ||
| import { NodeSDK } from "@opentelemetry/sdk-node"; | ||
| import { | ||
| AlwaysOnSampler, | ||
| BatchSpanProcessor, | ||
| } from "@opentelemetry/sdk-trace-base"; | ||
| import { ATTR_SERVICE_NAME } from "@opentelemetry/semantic-conventions"; | ||
|
|
||
| const sdk = new NodeSDK({ | ||
| resource: new Resource({ | ||
| [ATTR_SERVICE_NAME]: "ctrlplane/event-worker", | ||
| }), | ||
| spanProcessors: [new BatchSpanProcessor(new OTLPTraceExporter())], | ||
| logRecordProcessors: [new BatchLogRecordProcessor(new OTLPLogExporter())], | ||
| instrumentations: [ | ||
| getNodeAutoInstrumentations({ | ||
| "@opentelemetry/instrumentation-fs": { | ||
| enabled: false, | ||
| }, | ||
| "@opentelemetry/instrumentation-net": { | ||
| enabled: false, | ||
| }, | ||
| "@opentelemetry/instrumentation-dns": { | ||
| enabled: false, | ||
| }, | ||
| "@opentelemetry/instrumentation-http": { | ||
| enabled: true, | ||
| }, | ||
| "@opentelemetry/instrumentation-pg": { | ||
| enabled: true, | ||
| enhancedDatabaseReporting: true, | ||
| addSqlCommenterCommentToQueries: true, | ||
| }, | ||
| "@opentelemetry/instrumentation-ioredis": { | ||
| enabled: true, | ||
| }, | ||
| "@opentelemetry/instrumentation-winston": { | ||
| enabled: true, | ||
| logHook: (span, record) => { | ||
| record["resource.service.name"] = "ctrlplane/event-worker"; | ||
| }, | ||
| }, | ||
| }), | ||
| ], | ||
| sampler: new AlwaysOnSampler(), | ||
| }); | ||
|
|
||
| try { | ||
| sdk.start(); | ||
| console.log("Tracing initialized"); | ||
| } catch (error) { | ||
| console.error("Error initializing tracing", error); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export async function register() { | ||
| if (process.env.NEXT_RUNTIME === "nodejs") | ||
| await import("./instrumentation-node.js"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider graceful shutdown of the OpenTelemetry SDK
The SDK is started correctly, but there's no mechanism to shut it down gracefully when the application terminates. Consider adding a shutdown function that can be called during the application's shutdown process.
try { sdk.start(); console.log("Tracing initialized"); + + // Register shutdown handler + process.on('beforeExit', async () => { + await sdk.shutdown(); + console.log("Tracing terminated"); + }); } catch (error) { console.error("Error initializing tracing", error); }Alternatively, you could export a shutdown function that can be called from the main shutdown handler in index.ts:
try { sdk.start(); console.log("Tracing initialized"); } catch (error) { console.error("Error initializing tracing", error); } +export async function shutdownTracing() { + return sdk.shutdown(); +}📝 Committable suggestion