evaluate on cron

[jsbroks]

Summary by CodeRabbit

• New Features

  • Introduced an asynchronous evaluation process that pre-assesses operational criteria in batches, streamlining job processing.

• Chores

  • Added a new dependency to enhance event-driven capabilities.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a new dependency, @ctrlplane/events, to the jobs package and adds an asynchronous function, triggerPolicyEvaluation, in the policy checker module. The new function fetches release targets from the database in paginated chunks and enqueues them for evaluation. Additionally, the run function is modified to call triggerPolicyEvaluation at the start of its execution.

Changes

File Path	Change Summary
apps/jobs/package.json	Added dependency "@ctrlplane/events": "workspace:*".
apps/jobs/src/policy-checker/index.ts	Added new async function triggerPolicyEvaluation for paginated evaluation of release targets, and updated the run function to call this new function at startup.

Sequence Diagram(s)

sequenceDiagram
    participant Runner as run()
    participant Evaluator as triggerPolicyEvaluation()
    participant DB as Database
    participant Queue as Evaluation Queue

    Runner->>Evaluator: Call triggerPolicyEvaluation()
    loop Fetch release targets in chunks
        Evaluator->>DB: Query release targets (limit=1000, offset)
        DB-->>Evaluator: Return release targets
        alt Targets found
            Evaluator->>Queue: Enqueue evaluation tasks
        else No targets
            Evaluator-->>Evaluator: Exit loop
        end
    end
    Runner->>Runner: Continue with job dispatch

Loading

Poem

I'm just a rabbit hopping through the code,
With new events to lighten my digital load.
A function to evaluate, a loop to explore,
Hopping through targets, I always want more.
In each line of code, a playful skip so free,
Celebrating changes with joy and glee! 🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d89e597 and 41c8d74.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

• apps/jobs/src/policy-checker/index.ts (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6bee9f and 71b271b.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• apps/jobs/package.json (1 hunks)
• apps/jobs/src/policy-checker/index.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/jobs/src/policy-checker/index.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: build (linux/amd64)
• GitHub Check: Typecheck
• GitHub Check: Lint
• GitHub Check: Test
• GitHub Check: build (linux/amd64)

🔇 Additional comments (2)

apps/jobs/package.json (1)

17-17: LGTM: New dependency for event handling added.

The addition of "@ctrlplane/events": "workspace:*" correctly references the workspace package that will be used for the new policy evaluation functionality.

apps/jobs/src/policy-checker/index.ts (1)

4-4: LGTM: Imported required modules from new dependency.

The import statement correctly brings in the Channel and getQueue functions from the newly added events package.