chore: Readd resource workers

[adityachoudhari26]

Summary by CodeRabbit

• New Features
  • New resource processing now actively enqueues tasks for further actions.
• Refactor
  • Streamlined the workflow for processing updates by clearly managing insertions and removals concurrently.
• Chores
  • Removed obsolete code to improve overall clarity and efficiency.

[coderabbitai]

Walkthrough

The changes re-enable and refine the handling of release targets across several modules in the event worker. The previously commented code in the utility for upserting release targets is now active, ensuring that targets are inserted into the database with conflict handling. Additionally, both the new resource and updated resource workers have been modified: the new resource worker now processes resources by upserting release targets and queuing jobs, while the updated resource worker captures results to filter out and delete stale targets and concurrently dispatch exit hooks along with evaluation queue updates.

Changes

File(s)	Change Summary
apps/event-worker/src/utils/upsert-release-targets.ts	Removed commented-out code in the upsertReleaseTargets function; now checks for empty release target entries and inserts targets into the database using onConflictDoNothing().
apps/event-worker/src/workers/new-resource.ts	Modified newResourceWorker to call upsertReleaseTargets with the database and resource; maps returned release targets into job objects and enqueues them in bulk via queue.addBulk().
apps/event-worker/src/workers/updated-resources/index.ts	Updated updatedResourceWorker to capture the result of upsertReleaseTargets, filter out current release targets that need deletion, and perform deletions via db.delete; concurrently dispatches exit hooks and enqueues evaluation jobs using Promise.allSettled().

Sequence Diagram(s)

sequenceDiagram
    participant NRW as newResourceWorker
    participant DB as Database/upsertReleaseTargets
    participant Q as Job Queue

    NRW ->> DB: Call upsertReleaseTargets(db, resource)
    DB -->> NRW: Return list of release targets (rts)
    NRW ->> NRW: Map rts to job objects
    NRW ->> Q: Enqueue jobs in bulk (queue.addBulk)

Loading

sequenceDiagram
    participant URW as updatedResourceWorker
    participant DB as Database (upsert & delete)
    participant H as Exit Hooks/Evaluation Queue

    URW ->> DB: Call upsertReleaseTargets and capture result
    URW ->> URW: Filter currentReleaseTargets against upsertedReleaseTargets
    URW ->> DB: Delete stale release targets (db.delete)
    URW ->> H: Dispatch exit hooks & add to evaluation queue concurrently

Loading

Poem

I'm a rabbit, hopping with code so bright,
Uncovering logic lost in plain sight.
Release targets now dance in the DB maze,
With queued jobs leaping through gleeful arrays.
Hopping in rhythms, my heart sings with delight! 🐰✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48f6589 and 89b1574.

📒 Files selected for processing (3)

• apps/event-worker/src/utils/upsert-release-targets.ts (1 hunks)
• apps/event-worker/src/workers/new-resource.ts (1 hunks)
• apps/event-worker/src/workers/updated-resources/index.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/event-worker/src/utils/upsert-release-targets.ts
• apps/event-worker/src/workers/updated-resources/index.ts
• apps/event-worker/src/workers/new-resource.ts

🧬 Code Graph Analysis (2)

apps/event-worker/src/workers/updated-resources/index.ts (4)

apps/event-worker/src/utils/upsert-release-targets.ts (1)

• upsertReleaseTargets (42-64)

apps/event-worker/src/workers/updated-resources/dispatch-exit-hooks.ts (1)

• dispatchExitHooks (75-90)

packages/events/src/index.ts (1)

• getQueue (26-32)

packages/logger/src/index.ts (1)

• logger (44-44)

apps/event-worker/src/workers/new-resource.ts (2)

apps/event-worker/src/utils/upsert-release-targets.ts (1)

• upsertReleaseTargets (42-64)

packages/db/src/schema/resource.ts (1)

• resource (59-87)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Typecheck
• GitHub Check: Lint
• GitHub Check: build (linux/amd64)

🔇 Additional comments (5)

apps/event-worker/src/utils/upsert-release-targets.ts (1)

58-63: Effective reactivation of release target insertion logic

The uncommented code properly handles the insertion of release targets with appropriate conflict handling. This implementation correctly returns early for empty inserts and uses onConflictDoNothing() to handle potential duplicates gracefully.

apps/event-worker/src/workers/new-resource.ts (1)

10-15: Well-implemented resource processing flow

The implementation now properly processes new resources by upserting release targets and queuing evaluation jobs. The job naming convention using composite keys (${rt.resourceId}-${rt.environmentId}-${rt.deploymentId}) provides good traceability.

apps/event-worker/src/workers/updated-resources/index.ts (3)

19-22: Good use of variable capture for processing flow

Storing the upserted release targets in a variable and using it to filter targets for deletion creates a clear and maintainable processing flow. The filtering logic correctly identifies targets that should be removed.

---

24-29: Appropriate database operation for target deletion

The implementation correctly uses inArray with the release target IDs to efficiently delete multiple targets in a single operation.

---

31-50: Improved concurrency with Promise.allSettled

Using Promise.allSettled for concurrent processing of exit hooks and queue updates is an excellent approach. This pattern ensures that both operations are awaited together without one blocking the other, potentially improving performance.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.