-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Load instrumentation-node ahead of time #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the Node process startup and instrumentation initialization for the event-worker. In the Dockerfile, the startup command now preloads an instrumentation module before executing the main application. Concurrently, the manual instrumentation registration in the main application (index.ts) has been removed, shifting the initialization responsibilities entirely to the module loaded via the command-line flag. Changes
Sequence Diagram(s)sequenceDiagram
participant D as Docker Container
participant N as Node Process
participant I as Instrumentation Module
participant A as Main App (index.js)
D->>N: Execute CMD with "-r ./instrumentation-node.js"
N->>I: Preload instrumentation module
I-->>N: Initialize instrumentation setup
N->>A: Launch main application script
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Summary by CodeRabbit