fix: move queue insert out of tx in env create endpoint

[adityachoudhari26]

Summary by CodeRabbit

• Refactor

  • Improved the process for handling environment creation and updates to separate checks and transactional operations, enhancing reliability and maintainability.

• Tests

  • Enhanced environment matching tests with more precise resource selection criteria to ensure better accuracy in test validations.

[coderabbitai]

Walkthrough

This update refactors the POST handler for environment creation in the web service API. The existence check for an environment by name is now performed before starting the database transaction, rather than inside it. The transaction is limited to the upsert operation and related tasks. After the transaction, the code conditionally enqueues update or creation events based on whether the environment previously existed. Corresponding end-to-end tests were updated to use a more complex resource selector and to refine the assertions for resource matching. A trailing blank line was also removed from a YAML test configuration file.

Changes

File(s)	Change Summary
apps/webservice/src/app/api/v1/environments/route.ts	Refactored POST handler: moved environment existence check outside transaction, limited transaction scope, and updated event queuing logic.
e2e/tests/api/environments.spec.ts	Enhanced test for resource matching: updated resourceSelector to use composite conditions and refined assertions.
e2e/tests/api/environments.spec.yaml	Removed trailing blank line; no functional changes.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API
    participant DB
    participant Queue

    Client->>API: POST /environments
    API->>DB: Check if environment exists by name
    alt Environment exists or not
        API->>DB: Begin transaction
        API->>DB: Upsert environment and related data
        API->>DB: Commit transaction
    end
    alt Environment existed before
        API->>Queue: Enqueue update event
    else New environment
        API->>Queue: Enqueue creation event
    end
    API-->>Client: Respond with result

Loading

Possibly related PRs

• feat: new env worker #502: Introduces a new environment worker and modifies event queueing logic, directly related to how environment events are enqueued after the transaction.
• fix: Environment create route supports upsert #424: Refactors the same POST handler by removing the existence check and switching to an upsert operation, affecting similar logic in the route.

Suggested reviewers

• jsbroks

Poem

In the warren of code, a new path we tread,
Checks moved outside, transactions ahead.
Events now queued with a hop and a cheer,
Tests grow smarter, intentions made clear.
🐇 With every refactor, our garden grows bright—
Environments flourish in the soft morning light!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e018699 and 9d955b4.

📒 Files selected for processing (1)

• e2e/tests/api/environments.spec.yaml (0 hunks)

💤 Files with no reviewable changes (1)

• e2e/tests/api/environments.spec.yaml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.