fix: actually delete unmatched release targets

[adityachoudhari26]

Summary by CodeRabbit

• Bug Fixes

  • Obsolete release targets are now automatically removed during updates, ensuring only current release targets remain active.

• Chores

  • Removed detailed logging related to new release creation for release targets.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce logic to identify and delete obsolete release targets during the transactional update process in the compute-systems-release-targets worker. This ensures that release targets no longer matching the current deployment, resource, and environment combinations are removed from the database before new release targets are inserted. Additionally, a logging statement related to release creation in the evaluate-release-target worker is removed. No alterations are made to exported or public entity declarations.

Changes

File(s)	Change Summary
apps/event-worker/src/workers/compute-systems-release-targets.ts	Added logic to filter and delete obsolete release targets before inserting new ones within a transaction.
apps/event-worker/src/workers/evaluate-release-target.ts	Removed a logging statement related to new release creation for a release target.

Sequence Diagram(s)

sequenceDiagram
    participant Worker as compute-systems-release-targets Worker
    participant DB as Database

    Worker->>DB: Retrieve existing release targets
    Worker->>Worker: Compute new release targets
    Worker->>Worker: Identify obsolete release targets
    alt If obsolete targets found
        Worker->>DB: Delete obsolete release targets
    end
    Worker->>DB: Insert new release targets

Loading

Possibly related PRs

• fix: Simplify new deployment version worker and add jsdocs #491: Related through handling of release targets, with a focus on utility function renaming and replacement.
• feat: delete resource worker #498: Both PRs involve deletion of release targets, though in different workflows (transactional update vs. resource deletion).
• fix: stabilize release creation and add e2e #518: Directly related through stabilization and modification of release target handling in the same function and file.

Suggested reviewers

• jsbroks

Poem

In the warren of code, we sweep and we prune,
Old targets now gone, like footprints on the moon.
With a hop and a skip, new releases take flight,
Obsolete bunnies vanish softly from sight.
Logs grow more silent, the meadow more clear—
A tidier patch for all rabbits this year! 🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67bcc39 and 3972cc7.

📒 Files selected for processing (2)

• apps/event-worker/src/workers/compute-systems-release-targets.ts (1 hunks)
• apps/event-worker/src/workers/evaluate-release-target.ts (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.