feat(ComboBox): sections support #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 771f796 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for cube-uikit-docs failed.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-a0015e8. |
🏗 Docs are successfully deployed!👀 Preview: https://68519fcf7f55a2444d750eab--cube-uikit-docs.netlify.app |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for sections across the ComboBox, Menu, and Select components while updating token values and refactoring styled component names for clarity.
- Updates design tokens to include separate bold weights.
- Refactors styled components in Menu and adjusts component imports and naming for consistent sections support.
- Implements divider insertion between sections and adds Section support in Select and ComboBox along with corresponding stories.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tokens.ts | Updated font weight tokens and added bold-weight entries |
| src/components/pickers/Menu/styled.tsx | Renamed styled components and updated QA attributes |
| src/components/pickers/Menu/MenuSection.tsx | Updated imports to match new styled component names |
| src/components/pickers/Menu/MenuItem.tsx | Adjusted to use the renamed StyledItem |
| src/components/pickers/Menu/Menu.tsx | Reworked menu rendering to insert dividers between sections |
| src/components/pickers/Menu/Menu.stories.tsx | Removed Divider usage in stories in favor of sections support |
| src/components/fields/Select/Select.tsx | Modified ListBox styling and implemented section rendering logic |
| src/components/fields/Select/Select.stories.tsx | Added Section support in Select stories |
| src/components/fields/ComboBox/ComboBox.tsx | Extended ComboBox support to include sections and updated state props |
| src/components/fields/ComboBox/ComboBox.stories.tsx | Added static and dynamic section stories for ComboBox |
| .changeset/*.md | Updated changeset files for new section support changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
Checklist
Before taking this PR from the draft, please, make sure you have done the following:
Closes: N/A
Other information