feat: add new chart icons #705
Conversation
🦋 Changeset detectedLatest commit: 678d638 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for cube-uikit-docs failed.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-0c19580. |
🏗 Docs are successfully deployed!👀 Preview: https://68540e549ad995d77899af40--cube-uikit-docs.netlify.app |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a set of new chart icons and updates the Storybook demo to display them with the Text component and correct sizing labels.
- Exported nine new chart icons in the icons index
- Added corresponding SVG icon components under
src/icons - Updated Storybook
Icons.stories.tsxto useTextfor icon labels and adjust the 24px section title
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/icons/index.ts | Export new chart icons |
| src/icons/*.tsx | Add nine new chart icon components |
| src/icons/Icons.stories.tsx | Use <Text> instead of <span> and update size label |
| .changeset/olive-lions-notice.md | Declare a patch release for new icons |
Comments suppressed due to low confidence (2)
src/icons/ChartScatterIcon.tsx:1
- New icons like ChartScatterIcon lack associated unit or snapshot tests; consider adding tests to verify correct SVG output and prevent regressions.
import { wrapIcon } from './wrap-icon';
src/icons/Icons.stories.tsx:50
- [nitpick] The label 'full-size' may be unclear; consider using more descriptive or consistent terminology such as 'default size' to align with design system conventions.
<Title>24px (full-size)</Title>
| export { CalendarIcon } from './CalendarIcon'; | ||
| export { CaretDownIcon } from './CaretDownIcon'; | ||
| export { CaretUpIcon } from './CaretUpIcon'; | ||
| export { ChartBarGroupedIcon } from './ChartBarGroupedIcon'; |
There was a problem hiding this comment.
[nitpick] Manually adding each new icon export increases maintenance overhead; consider automating barrel file generation or using a script to keep the index in sync.
No description provided.