Skip to content

Conversation

@tenphi
Copy link
Member

@tenphi tenphi commented Sep 1, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

🦋 Changeset detected

Latest commit: 6169751

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cube-ui-kit Ready Ready Preview Comment Sep 3, 2025 3:43pm
cube-ui-kit-cursor Ready Ready Preview Comment Sep 3, 2025 3:43pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-cd10ed1.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

🏋️ Size limit report

Name Size Passed?
All 298.17 KB (+0.2% 🔺) Yes 🎉
Tree shaking (just a Button) 31.44 KB (+2.86% 🔺) Yes 🎉
Tree shaking (just an Icon) 19.33 KB (+4.76% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the style injector's cleanup mechanism by adding batch processing and age-based filtering to prevent races during rapid mount/unmount cycles.

  • Added configuration options for batch ratio and minimum age thresholds for cleanup
  • Implemented age-based filtering and sorting for cleanup candidates
  • Added safety checks to ensure sheet elements exist before deletion

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/tasty/injector/types.ts Added new configuration options for bulk cleanup batch ratio and minimum age
src/tasty/injector/sheet-manager.ts Implemented improved cleanup logic with age filtering and batch processing
src/tasty/injector/index.ts Set default values for new configuration options
.changeset/breezy-planes-talk.md Added changeset documentation for the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant