-
Notifications
You must be signed in to change notification settings - Fork 6
fix(tasty): cleanup method #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6169751 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-cd10ed1. |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the style injector's cleanup mechanism by adding batch processing and age-based filtering to prevent races during rapid mount/unmount cycles.
- Added configuration options for batch ratio and minimum age thresholds for cleanup
- Implemented age-based filtering and sorting for cleanup candidates
- Added safety checks to ensure sheet elements exist before deletion
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tasty/injector/types.ts | Added new configuration options for bulk cleanup batch ratio and minimum age |
| src/tasty/injector/sheet-manager.ts | Implemented improved cleanup logic with age filtering and batch processing |
| src/tasty/injector/index.ts | Set default values for new configuration options |
| .changeset/breezy-planes-talk.md | Added changeset documentation for the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.