Skip to content

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Oct 7, 2025

Note

Adds a new Picker component with docs/tests, refactors ComboBox filtering and blur/keyboard handling, introduces ListBox-level filtering support, and tweaks popover/dialog behavior and QA attributes.

  • New Component: Picker
    • Implements Picker with trigger + ListBox popover, single/multiple selection, clear button, custom summary, sections, sorting, and form integration.
    • Adds stories (Picker.stories.tsx), docs (Picker.docs.mdx), tests (Picker.test.tsx), and exports in fields/index.ts.
  • ComboBox:
    • Refactors filtering to a collection-based filterFn; passes filter to ListBox.
    • Improves blur behavior: auto-select single match; clear invalid/empty input (with/without clearOnBlur); reset to selected value when invalid.
    • Enhances keyboard handling (Enter selects focused item; clears on empty Enter; Escape/Arrow behavior) and hasResults calculation.
    • Uses local useListState for label lookup; stability fixes for controlled selectedKey sync.
    • Updates stories/tests to cover new behaviors.
  • ListBox:
    • Adds filter prop and forwards to internal state; sets disabledBehavior: 'all'; marks isVirtualized: true.
    • QA/layout tweaks (wrapper/list QA ids, scroll container).
  • FilterListBox / FilterPicker:
    • QA/prop adjustments (qa ids, Omit filter), search/input wrapper tweaks, focus/option-click behavior retained; trigger QA updates.
  • Overlays:
    • Dialog popover height constrained to (50vh - 5x).
  • Tests/Setup:
    • New Picker test suite; additional ComboBox tests; suppress nested button warnings in test setup.
  • Release:
    • Changeset: @cube-dev/ui-kit minor bump adding Picker.

Written by Cursor Bugbot for commit fc33548. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025

🦋 Changeset detected

Latest commit: 2a2aea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cube-ui-kit Ready Ready Preview Comment Oct 22, 2025 9:47am
cube-ui-kit-cursor Ready Ready Preview Comment Oct 22, 2025 9:47am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-db41980.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

🏋️ Size limit report

Name Size Passed?
All 305.69 KB (+0.36% 🔺) Yes 🎉
Tree shaking (just a Button) 32.06 KB (0% 🟰) Yes 🎉
Tree shaking (just an Icon) 19.38 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@tenphi tenphi merged commit bb56ca5 into main Oct 22, 2025
14 checks passed
@tenphi tenphi deleted the feat-picker branch October 22, 2025 12:53
@github-actions github-actions bot mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant