Skip to content

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Oct 21, 2025

Note

Adjust qa assignment: set wrapper qa via tasty config, pass qa to input element, and omit form prop when wrapping.

  • TextInputBase (src/components/fields/TextInput/TextInputBase.tsx):
    • QA handling:
      • Set qa on InputWrapperElement via tasty({ qa: 'InputWrapper' }).
      • Remove qa from wrapper usage and pass qa={qa || 'Input'} to InputElement.
    • Field wrapping:
      • Exclude form by passing form: undefined to wrapWithField.
  • Changeset:
    • Patch release for @cube-dev/ui-kit with note: fix qa prop on TextInputBase.

Written by Cursor Bugbot for commit 1a15cab. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

🦋 Changeset detected

Latest commit: 1a15cab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cube-ui-kit Ready Ready Preview Comment Oct 21, 2025 2:04pm
cube-ui-kit-cursor Ready Ready Preview Comment Oct 21, 2025 2:04pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@github-actions
Copy link
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-acfe825.

@github-actions
Copy link
Contributor

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 304.55 KB (+0.01% 🔺) Yes 🎉
Tree shaking (just a Button) 32.06 KB (0% 🟰) Yes 🎉
Tree shaking (just an Icon) 19.38 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@tenphi tenphi merged commit f80593b into main Oct 21, 2025
14 checks passed
@tenphi tenphi deleted the fix-textinput-qa branch October 21, 2025 16:05
@github-actions github-actions bot mentioned this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant