Skip to content

Conversation

@tenphi
Copy link
Member

@tenphi tenphi commented Nov 19, 2025

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information


Note

Properly merges user-provided labelProps with aria-generated props across multiple input/field components to prevent overrides and enable customization.

  • Fields/Input components
    • Merge user labelProps with aria labelProps via mergeProps to avoid overrides and allow customization
    • Affected components: TextInput, NumberInput, PasswordInput, TextArea, SearchInput, SliderBase (for Slider/RangeSlider), TimeInput
  • Changeset
    • Add patch changeset: /.changeset/fix-labelprops-merge.md
    • Update changeset rules in /.cursor/rules/changeset.mdc

Written by Cursor Bugbot for commit 75c15da. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

🦋 Changeset detected

Latest commit: 75c15da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cube-ui-kit Ready Ready Preview Comment Nov 19, 2025 4:23pm
cube-ui-kit-cursor Ready Ready Preview Comment Nov 19, 2025 4:23pm

@github-actions
Copy link
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-193c101.

@github-actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 297.46 KB (0% 🟰) Yes 🎉
Tree shaking (just a Button) 33.41 KB (0% 🟰) Yes 🎉
Tree shaking (just an Icon) 20.68 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Contributor

🧪 Storybook is successfully deployed!

@tenphi tenphi merged commit d48e94a into main Nov 19, 2025
19 checks passed
@tenphi tenphi deleted the feat-text-input-field-props branch November 19, 2025 16:34
@github-actions github-actions bot mentioned this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants