fix(Select): qa prop #897
fix(Select): qa prop #897
Conversation
🦋 Changeset detectedLatest commit: c8e8c42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-063d13c. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| name={name} | ||
| accept={accept} | ||
| data-qa={qa || 'FileInput'} | ||
| data-input-type="fileinput" |
There was a problem hiding this comment.
Bug: Undocumented breaking change to FileInput QA selector
The qa prop was moved from the wrapper to the hidden input element. This undocumented breaking change prevents tests from asserting on visible text (filename) via the QA selector, as the text is in a sibling element. It also contradicts the PR title which focuses only on Select.
| name={name} | ||
| accept={accept} | ||
| data-qa={qa || 'FileInput'} | ||
| data-input-type="fileinput" |
There was a problem hiding this comment.
Bug: Breaking change to FileInput QA structure affecting text assertions
The qa prop and data-input-type were moved from the FileInput wrapper to the hidden input element. This prevents tests from asserting on visible text (filename) via the main QA selector, as the text resides in a sibling element. This change is undocumented and contradicts the PR title which only focuses on Select.
Note
Adds disabled handling to FileInput and fixes qa/data-qa wiring for FileInput and Select, with minor trigger/styling tweaks.
src/components/fields/FileInput/FileInput.tsx):isDisabledsupport (disables input, wrapper mods).qatodata-qaon<input>, add wrapperqaasFileInputWrapper, adddata-input-type.top: 0).src/components/fields/Select/Select.tsx):SelectTriggerwithItem as="button"; setqaon trigger and adddata-input-type="select".data-input-type; keep HiddenSelect withoutqa.Written by Cursor Bugbot for commit c8e8c42. This will update automatically on new commits. Configure here.