Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Nov 24, 2025

Jinja instance stores all templates, because it resolves dependencies inside minijinja. If we have at least one jinja file, then compiler load all templates to jinja instance.

@ovr ovr requested a review from a team as a code owner November 24, 2025 12:51
@ovr ovr requested a review from KSDaemon November 24, 2025 12:51
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.64%. Comparing base (d8b8deb) to head (09e017a).
⚠️ Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d8b8deb) and HEAD (09e017a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d8b8deb) HEAD (09e017a)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10169       +/-   ##
===========================================
- Coverage   83.28%   54.64%   -28.64%     
===========================================
  Files         244      214       -30     
  Lines       74180    16995    -57185     
  Branches        0     3471     +3471     
===========================================
- Hits        61781     9287    -52494     
+ Misses      12399     7208     -5191     
- Partials        0      500      +500     
Flag Coverage Δ
cube-backend 54.64% <100.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr merged commit ec7ca2f into master Nov 24, 2025
74 of 75 checks passed
@ovr ovr deleted the fix/schema-compiler-jinja-free-memory branch November 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants