Skip to content

fix(client-core): Fix TypeScript module resolution via exports.types #10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

fix(client-core): Fix TypeScript module resolution via exports.types #10209

merged 1 commit into from
Dec 1, 2025

Conversation

@spikebrehm
Copy link
Contributor

@spikebrehm spikebrehm commented Dec 1, 2025

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#10015

Description of Changes Made

This should fix TypeScript module resolution for apps using "moduleResolution": "Node16" or "moduleResolution": "NodeNext".

@spikebrehm spikebrehm requested a review from a team as a code owner December 1, 2025 16:48
@github-actions github-actions bot added dependencies Pull requests that update a dependency file client:core Issues relating to the JavaScript client SDK pr:community Contribution from Cube.js community members. labels Dec 1, 2025
@spikebrehm spikebrehm mentioned this pull request Dec 1, 2025
Open
@vasilev-alex vasilev-alex merged commit 6f4a650 into cube-js:master Dec 1, 2025
3 checks passed
@spikebrehm spikebrehm deleted the exports-types branch December 1, 2025 17:23
@spikebrehm
Copy link
Contributor Author

spikebrehm commented Dec 1, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vasilev-alex vasilev-alex vasilev-alex approved these changes

Assignees

No one assigned

Labels

client:core Issues relating to the JavaScript client SDK dependencies Pull requests that update a dependency file pr:community Contribution from Cube.js community members.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spikebrehm @vasilev-alex