Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Dec 9, 2025

No description provided.

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Dec 9, 2025
@ovr ovr marked this pull request as ready for review December 9, 2025 14:31
@ovr ovr requested a review from a team as a code owner December 9, 2025 14:31
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 45.26316% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.09%. Comparing base (4c3029c) to head (6a733bb).

Files with missing lines Patch % Lines
...ejs-api-gateway/src/ws/local-subscription-store.ts 3.70% 26 Missing ⚠️
...s/cubejs-api-gateway/src/ws/subscription-server.ts 68.00% 16 Missing ⚠️
packages/cubejs-server/src/websocket-server.ts 0.00% 7 Missing ⚠️
packages/cubejs-api-gateway/src/ws/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10231      +/-   ##
==========================================
+ Coverage   54.85%   55.09%   +0.24%     
==========================================
  Files         219      221       +2     
  Lines       17061    17109      +48     
  Branches     3488     3498      +10     
==========================================
+ Hits         9359     9427      +68     
+ Misses       7205     7184      -21     
- Partials      497      498       +1     
Flag Coverage Δ
cube-backend 55.09% <45.26%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ovr added 3 commits December 9, 2025 16:08
# Conflicts:
#	packages/cubejs-api-gateway/src/gateway.ts
#	packages/cubejs-api-gateway/src/index.ts
#	packages/cubejs-api-gateway/src/query.js
#	packages/cubejs-api-gateway/src/ws/local-subscription-store.ts
#	packages/cubejs-api-gateway/src/ws/subscription-server.ts
@ovr ovr force-pushed the fix/improve-sanitization branch from f2fc1c8 to f3b4df5 Compare December 9, 2025 15:08
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@ovr ovr merged commit 6271520 into master Dec 9, 2025
66 of 69 checks passed
@ovr ovr deleted the fix/improve-sanitization branch December 9, 2025 17:02
ovr added a commit that referenced this pull request Dec 11, 2025
ovr added a commit that referenced this pull request Dec 11, 2025
ovr added a commit that referenced this pull request Dec 11, 2025
ovr added a commit that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants