Skip to content

feat(cubesql): Allow grouped joins with SQL push down#10234

Merged
MazterQyou merged 1 commit into
masterfrom
cubesql/grouped-join-grouped-sql-push-down
May 20, 2026
Merged

feat(cubesql): Allow grouped joins with SQL push down#10234
MazterQyou merged 1 commit into
masterfrom
cubesql/grouped-join-grouped-sql-push-down

Conversation

@MazterQyou
Copy link
Copy Markdown
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds support for joins when both sides are grouped to be used with SQL push down. Related test is included.

@MazterQyou MazterQyou requested review from a team as code owners December 10, 2025 02:38
@github-actions github-actions Bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Dec 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 92.79778% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.93%. Comparing base (3d59c59) to head (e194273).

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 82.35% 21 Missing ⚠️
.../cubesql/src/compile/rewrite/rules/wrapper/join.rs 97.27% 3 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 97.95% 1 Missing ⚠️
...t/cubesql/cubesql/src/compile/test/test_wrapper.rs 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10234      +/-   ##
==========================================
- Coverage   83.47%   78.93%   -4.55%     
==========================================
  Files         254      470     +216     
  Lines       75490    92793   +17303     
  Branches        0     3436    +3436     
==========================================
+ Hits        63014    73242   +10228     
- Misses      12476    19049    +6573     
- Partials        0      502     +502     
Flag Coverage Δ
cube-backend 58.38% <ø> (?)
cubesql 83.52% <92.79%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou force-pushed the cubesql/grouped-join-grouped-sql-push-down branch from 3d81b3d to 00d1a0c Compare February 5, 2026 22:04
@MazterQyou MazterQyou force-pushed the cubesql/grouped-join-grouped-sql-push-down branch from 00d1a0c to 16d2bf0 Compare March 16, 2026 12:30
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the cubesql/grouped-join-grouped-sql-push-down branch from 16d2bf0 to e194273 Compare May 19, 2026 17:57
@MazterQyou MazterQyou merged commit 041d753 into master May 20, 2026
190 of 194 checks passed
@MazterQyou MazterQyou deleted the cubesql/grouped-join-grouped-sql-push-down branch May 20, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants