fix(cubejs-questdb-driver): unsupported HAVING clause#10285
Merged
Conversation
github-actions
Bot
added
driver:questdb
javascript
Contributor
Author
|
The failed tests look unrelated unless I'm missing something. |
Contributor
Author
|
@igorlukanin could you review this one? We have a user who's waiting for this fix. |
waralexrom
approved these changes
Feb 27, 2026
Contributor
Author
|
@waralexrom thanks for the review! Any chances that the fix goes into one of the upcoming releases? @peterklingelhofer is waiting for this fix for a while now. |
Contributor
|
@waralexrom Any chance we can include this in an upcoming release? This would help us clean up our Cube schemas considerably if merged. Thank you. |
ovr
force-pushed
the
questdb_fix_having_clause
branch
from
f13e0fd to
d10dfbf
Compare
Member
|
/bot-deep-review |
Contributor
Author
|
@ovr thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10148
Check List