Skip to content

feat(cubestore-driver): improve WebSocket connection error messages#10355

Merged
ovr merged 1 commit into
masterfrom
fix/cubestore-reconnection-error
Feb 4, 2026
Merged

feat(cubestore-driver): improve WebSocket connection error messages#10355
ovr merged 1 commit into
masterfrom
fix/cubestore-reconnection-error

Conversation

@ovr
Copy link
Copy Markdown
Member

@ovr ovr commented Feb 3, 2026

Add ConnectionError class to wrap WebSocket errors with CubeStore context, making it easier to diagnose connection failures.

Add ConnectionError class to wrap WebSocket errors with CubeStore context,
making it easier to diagnose connection failures.
@github-actions github-actions Bot added javascript Pull requests that update Javascript code data source driver labels Feb 3, 2026
@ovr ovr marked this pull request as ready for review February 3, 2026 17:24
@ovr ovr requested a review from a team as a code owner February 3, 2026 17:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.16%. Comparing base (fd8a312) to head (da5112e).
⚠️ Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (fd8a312) and HEAD (da5112e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fd8a312) HEAD (da5112e)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10355       +/-   ##
===========================================
- Coverage   77.99%   55.16%   -22.83%     
===========================================
  Files         469      221      -248     
  Lines       91781    17295    -74486     
  Branches     3539     3539               
===========================================
- Hits        71582     9541    -62041     
+ Misses      19704     7259    -12445     
  Partials      495      495               
Flag Coverage Δ
cube-backend 55.16% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr merged commit 76b7873 into master Feb 4, 2026
38 checks passed
@ovr ovr deleted the fix/cubestore-reconnection-error branch February 4, 2026 15:37
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
…ube-js#10355)

Add ConnectionError class to wrap WebSocket errors with CubeStoreDriver's context, making it easier to diagnose connection failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant