Skip to content

feat(backend-native): Add throwContinueWait parameter to /cubesql API endpoint#10385

Merged
MazterQyou merged 1 commit intomasterfrom
backend-native/cubesql-force-continue-wait
Mar 4, 2026
Merged

feat(backend-native): Add throwContinueWait parameter to /cubesql API endpoint#10385
MazterQyou merged 1 commit intomasterfrom
backend-native/cubesql-force-continue-wait

Conversation

@MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Feb 10, 2026

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds throwContinueWait optional boolean parameter to /cubesql API endpoint which, when enabled, surfaces Continue wait errors over HTTP transport instead of looping and holding the connection indefinitely.

@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Feb 10, 2026
@MazterQyou MazterQyou force-pushed the backend-native/cubesql-force-continue-wait branch from a98b59e to e8b28db Compare February 10, 2026 12:15
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.51%. Comparing base (1f5716a) to head (44aa6e7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-api-gateway/src/sql-server.ts 0.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10385      +/-   ##
==========================================
- Coverage   83.36%   78.51%   -4.85%     
==========================================
  Files         250      472     +222     
  Lines       74886    92294   +17408     
  Branches        0     3563    +3563     
==========================================
+ Hits        62429    72469   +10040     
- Misses      12457    19287    +6830     
- Partials        0      538     +538     
Flag Coverage Δ
cube-backend 57.65% <50.00%> (?)
cubesql 83.36% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou force-pushed the backend-native/cubesql-force-continue-wait branch from e8b28db to 50ee13d Compare February 10, 2026 12:26
@hank-sq
Copy link
Contributor

hank-sq commented Feb 10, 2026

I actually just filed this #10387 - funny timing! Thanks for working on this.

@MazterQyou MazterQyou force-pushed the backend-native/cubesql-force-continue-wait branch from 50ee13d to 98213dc Compare February 11, 2026 12:37
… API endpoint

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou marked this pull request as ready for review March 4, 2026 08:28
@MazterQyou MazterQyou requested review from a team as code owners March 4, 2026 08:28
@MazterQyou MazterQyou force-pushed the backend-native/cubesql-force-continue-wait branch from 98213dc to 44aa6e7 Compare March 4, 2026 08:28
@MazterQyou MazterQyou changed the title feat(backend-native): Add forceContinueWait parameter to /cubesql API endpoint feat(backend-native): Add throwContinueWait parameter to /cubesql API endpoint Mar 4, 2026
@MazterQyou MazterQyou merged commit 3687c5f into master Mar 4, 2026
122 of 123 checks passed
@MazterQyou MazterQyou deleted the backend-native/cubesql-force-continue-wait branch March 4, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants