Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Oct 24, 2025

An attempt to fix #9941: Unnecessary JOIN added when using FILTER_PARAMS in a segment

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.80%. Comparing base (765cd77) to head (f9ec086).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10084      +/-   ##
==========================================
+ Coverage   48.77%   48.80%   +0.02%     
==========================================
  Files         196      196              
  Lines       15840    15840              
  Branches     3105     3105              
==========================================
+ Hits         7726     7730       +4     
+ Misses       7722     7718       -4     
  Partials      392      392              
Flag Coverage Δ
cube-backend 48.80% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary JOIN added when using FILTER_PARAMS in a segment

1 participant