-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: ISSUE-5528 prestodb - replace double escaping in contain filter #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ISSUE-5528 prestodb - replace double escaping in contain filter #5529
Conversation
Codecov ReportBase: 72.15% // Head: 40.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5529 +/- ##
===========================================
- Coverage 72.15% 40.55% -31.60%
===========================================
Files 274 144 -130
Lines 28829 19319 -9510
Branches 3023 4889 +1866
===========================================
- Hits 20801 7835 -12966
- Misses 7724 11179 +3455
- Partials 304 305 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hey @yuraborue ! Thanks for contributing to this one! We'd really appreciate it if you can add the Presto E2E test, which tests this stuff. Example can be found here: https://github.com/cube-js/cube.js/blob/master/packages/cubejs-testing/test/smoke-materialize.test.ts |
|
Hi @paveltiunov ! I've added tests, could you review? |
|
@yuraborue Great! Could you please add the test to the |
|
@paveltiunov done! |
|
@yuraborue Looks great! Thanks! Yep. We need more bulletproof cleanup for this E2E test. |
Check List
Issue Reference this PR resolves
ISSUE-5528
Description of Changes Made (if issue reference is not provided)
Same with AthenaDriver hack