Skip to content

Conversation

@yuraborue
Copy link
Contributor

@yuraborue yuraborue commented Oct 27, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

ISSUE-5528

Description of Changes Made (if issue reference is not provided)

Same with AthenaDriver hack

@yuraborue yuraborue requested a review from a team as a code owner October 27, 2022 15:21
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 72.15% // Head: 40.55% // Decreases project coverage by -31.59% ⚠️

Coverage data is based on head (937a510) compared to base (d18b971).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5529       +/-   ##
===========================================
- Coverage   72.15%   40.55%   -31.60%     
===========================================
  Files         274      144      -130     
  Lines       28829    19319     -9510     
  Branches     3023     4889     +1866     
===========================================
- Hits        20801     7835    -12966     
- Misses       7724    11179     +3455     
- Partials      304      305        +1     
Flag Coverage Δ
cube-backend 40.55% <ø> (-19.34%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cubejs-schema-compiler/src/adapter/BaseMeasure.js 81.52% <0.00%> (-1.82%) ⬇️
...s-schema-compiler/src/adapter/BaseTimeDimension.js 80.37% <0.00%> (-0.02%) ⬇️
.../engine/information_schema/postgres/pg_settings.rs
...pile/engine/information_schema/postgres/pg_enum.rs
...cubesql/cubesql/src/compile/rewrite/rules/dates.rs
...ine/information_schema/postgres/testing_dataset.rs
...engine/information_schema/postgres/pg_namespace.rs
...formation_schema/postgres/pg_statio_user_tables.rs
.../compile/engine/information_schema/postgres/ext.rs
...mpile/engine/information_schema/postgres/tables.rs
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov
Copy link
Member

Hey @yuraborue ! Thanks for contributing to this one! We'd really appreciate it if you can add the Presto E2E test, which tests this stuff. Example can be found here: https://github.com/cube-js/cube.js/blob/master/packages/cubejs-testing/test/smoke-materialize.test.ts

@yuraborue yuraborue requested a review from a team as a code owner October 31, 2022 14:28
@yuraborue
Copy link
Contributor Author

Hi @paveltiunov ! I've added tests, could you review?

@paveltiunov
Copy link
Member

@yuraborue Great! Could you please add the test to the integration-smoke action? Thanks!

@yuraborue
Copy link
Contributor Author

@paveltiunov done!
btw - Build / Build & Test :dev for Debian without pushing (pull_request) looks flaky, was red on first try and green after restart

@paveltiunov
Copy link
Member

@yuraborue Looks great! Thanks! Yep. We need more bulletproof cleanup for this E2E test.

@paveltiunov paveltiunov merged commit 7870705 into cube-js:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants