Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Dec 16, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#874

@paveltiunov paveltiunov requested review from a team as code owners December 16, 2022 05:45
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 41.02% // Head: 60.85% // Increases project coverage by +19.83% 🎉

Coverage data is based on head (43ac4c2) compared to base (b527cd9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5842       +/-   ##
===========================================
+ Coverage   41.02%   60.85%   +19.83%     
===========================================
  Files         149      288      +139     
  Lines       19546    38116    +18570     
  Branches     5088     5090        +2     
===========================================
+ Hits         8018    23197    +15179     
- Misses      10708    14099     +3391     
  Partials      820      820               
Flag Coverage Δ
cube-backend 41.03% <100.00%> (+0.01%) ⬆️
cubesql 81.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/mod.rs 64.57% <ø> (ø)
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 70.47% <100.00%> (+0.04%) ⬆️
...ema-compiler/src/compiler/CubeToMetaTransformer.js 79.62% <100.00%> (+0.38%) ⬆️
...bejs-schema-compiler/src/compiler/CubeValidator.js 96.82% <100.00%> (+0.05%) ⬆️
...besql/cubesql/src/compile/rewrite/rules/members.rs 97.78% <100.00%> (ø)
rust/cubesql/cubesql/src/compile/test/mod.rs 92.75% <100.00%> (ø)
rust/cubesql/cubesql/src/transport/ext.rs 83.12% <100.00%> (ø)
...src/compile/engine/information_schema/mysql/ext.rs 100.00% <0.00%> (ø)
.../models/v1_load_request_query_filter_logical_or.rs 0.00% <0.00%> (ø)
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% <0.00%> (ø)
... and 136 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants