Skip to content

Conversation

@rpaik
Copy link
Contributor

@rpaik rpaik commented Dec 21, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 41.03% // Head: 82.12% // Increases project coverage by +41.09% 🎉

Coverage data is based on head (e46d3d3) compared to base (4d6511a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5855       +/-   ##
===========================================
+ Coverage   41.03%   82.12%   +41.09%     
===========================================
  Files         149      139       -10     
  Lines       19552    18910      -642     
  Branches     5090        0     -5090     
===========================================
+ Hits         8023    15530     +7507     
+ Misses      10709     3380     -7329     
+ Partials      820        0      -820     
Flag Coverage Δ
cube-backend ?
cubesql 82.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hema-compiler/src/extensions/extension.abstract.ts
...bejs-schema-compiler/src/compiler/CompilerCache.js
...-orchestrator/src/orchestrator/RedisCacheDriver.ts
...ges/cubejs-schema-compiler/src/parser/SqlParser.ts
...ema-compiler/src/compiler/CubeToMetaTransformer.js
...ubejs-schema-compiler/src/adapter/BigqueryQuery.js
...-orchestrator/src/orchestrator/LocalCacheDriver.ts
...ackages/cubejs-server-core/src/core/CompilerApi.js
...chestrator/src/orchestrator/RedisQueueEventsBus.ts
...ges/cubejs-schema-compiler/src/extensions/index.ts
... and 278 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rpaik rpaik marked this pull request as ready for review December 21, 2022 22:41
@rpaik rpaik requested a review from a team as a code owner December 21, 2022 22:41
@rpaik rpaik removed the request for review from a team December 21, 2022 22:41
@rpaik rpaik merged commit 1feb327 into master Dec 22, 2022
@rpaik rpaik deleted the rpaik-discourse-removal branch December 22, 2022 00:36
@igorlukanin
Copy link
Member

@rpaik Thanks for taking the lead on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants