Skip to content

Conversation

@hassankhan
Copy link
Contributor

No description provided.

@hassankhan hassankhan added the docs Issues that require a documentation improvement label Jan 16, 2023
@hassankhan hassankhan self-assigned this Jan 16, 2023
@hassankhan hassankhan force-pushed the _getting_started branch 10 times, most recently from 204df8a to 76c9087 Compare January 26, 2023 11:07
@hassankhan hassankhan force-pushed the _getting_started branch 3 times, most recently from 1275ab7 to 7a663a6 Compare January 27, 2023 18:12
@hassankhan hassankhan marked this pull request as ready for review January 31, 2023 10:40
@hassankhan hassankhan requested a review from a team as a code owner January 31, 2023 10:40
Copy link

@Rory-Cube Rory-Cube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hassankhan hassankhan force-pushed the _getting_started branch 6 times, most recently from 0677db0 to 13f3bf4 Compare March 28, 2023 22:30
@hassankhan
Copy link
Contributor Author

hassankhan commented Mar 29, 2023

@igorlukanin I think I've addressed most of your feedback. With regards to some of the minor feedback:

I think screenshots with borders (or browser window borders) would be more easy to study.

I have an example PR where we can add browser chrome via CSS, I'm not convinced there's value to us taking screenshots with all our tabs open 😅

I think it would be great if images span the whole page (not they have huge side margins).

Agreed, we can probably fix that for all images in the docs in a separate PR

We have a special "button" tag/style in blog (see example)

That would be awesome, but should probably be a part of a separate PR too

@hassankhan hassankhan merged commit 112300e into master Mar 31, 2023
@hassankhan hassankhan deleted the _getting_started branch March 31, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants