feat(cubestore-driver): Support persistent flag for query #6046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
697ecd3 to
08076d2
Compare
Codecov ReportBase: 41.41% // Head: 41.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6046 +/- ##
==========================================
+ Coverage 41.41% 41.57% +0.16%
==========================================
Files 151 152 +1
Lines 20086 20091 +5
Branches 5242 5242
==========================================
+ Hits 8318 8353 +35
+ Misses 11451 11428 -23
+ Partials 317 310 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
2 times, most recently
from
fcd9322 to
145a611
Compare
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
145a611 to
e322e93
Compare
ovr
commented
Jan 25, 2023
| // closing stream | ||
| if (query?.queryHandler === 'stream') { | ||
| const stream = this.getQueryStream(this.redisHash(queryKey)); | ||
| const stream = this.getQueryStream(queryKey); |
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
5c450ff to
f84c86f
Compare
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
e196e92 to
e8b565f
Compare
ovr
commented
Jan 25, 2023
| case 'stream': | ||
| const target = this.getQueryStream(queryKey); | ||
| await this.queryTimeout(this.queryHandlers.stream(query.query, target)); | ||
| await this.queryTimeout( |
buntarb
approved these changes
Jan 25, 2023
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
d2f5739 to
1bd87af
Compare
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
1bd87af to
7e64285
Compare
ovr
force-pushed
the
cubestore-driver-persistent-query
branch
from
160f6fb to
c139999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
refs #5042
Thanks